You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/23 11:41:53 UTC
[GitHub] [rocketmq-client-cpp] WoodsCumming opened a new pull request #257:
Modification item:
WoodsCumming opened a new pull request #257: Modification item:
URL: https://github.com/apache/rocketmq-client-cpp/pull/257
## What is the purpose of the change
(1)Declare variables explicitly, and clarify variable types.
(2)Format the code style.
(3)Add asan support for memory address out of range checking.
(4)Add lsan support for memory leak checking.
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] codecov-io edited a comment on issue #257:
Add asan/lsan support, and formatting code.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #257: Add asan/lsan support, and formatting code.
URL: https://github.com/apache/rocketmq-client-cpp/pull/257#issuecomment-590061154
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=h1) Report
> Merging [#257](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/b5794aea38063c1982651126db4e174baa0eb0ab?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257/graphs/tree.svg?width=650&token=L5As3jdqFW&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #257 +/- ##
======================================
Coverage 57.7% 57.7%
======================================
Files 182 182
Lines 11651 11651
======================================
Hits 6723 6723
Misses 4928 4928
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=footer). Last update [b5794ae...b153039](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] codecov-io commented on issue #257:
Modification item:
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #257: Modification item:
URL: https://github.com/apache/rocketmq-client-cpp/pull/257#issuecomment-590061154
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=h1) Report
> Merging [#257](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/b5794aea38063c1982651126db4e174baa0eb0ab?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257/graphs/tree.svg?width=650&token=L5As3jdqFW&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #257 +/- ##
======================================
Coverage 57.7% 57.7%
======================================
Files 182 182
Lines 11651 11651
======================================
Hits 6723 6723
Misses 4928 4928
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=footer). Last update [b5794ae...fbdedbf](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] codecov-io edited a comment on issue #257:
feat(memory): add asan/lsan support, and formatting code.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #257: feat(memory): add asan/lsan support, and formatting code.
URL: https://github.com/apache/rocketmq-client-cpp/pull/257#issuecomment-590061154
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=h1) Report
> Merging [#257](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/fe7d173406f4eeb113a91fafa52ac003f6fc6387?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257/graphs/tree.svg?width=650&token=L5As3jdqFW&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 57.69% 57.69%
=======================================
Files 182 182
Lines 11652 11652
=======================================
Hits 6723 6723
Misses 4929 4929
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=footer). Last update [fe7d173...bdf44a9](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] ShannonDing merged pull request #257:
feat(memory): add asan/lsan support, and formatting code.
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #257: feat(memory): add asan/lsan support, and formatting code.
URL: https://github.com/apache/rocketmq-client-cpp/pull/257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] codecov-io edited a comment on issue #257:
Add asan/lsan support, and formatting code.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #257: Add asan/lsan support, and formatting code.
URL: https://github.com/apache/rocketmq-client-cpp/pull/257#issuecomment-590061154
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=h1) Report
> Merging [#257](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/b1530391b3e760c5b2ffe70b77a0236acf812f08?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257/graphs/tree.svg?width=650&token=L5As3jdqFW&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
- Coverage 57.7% 57.69% -0.01%
==========================================
Files 182 182
Lines 11651 11652 +1
==========================================
Hits 6723 6723
- Misses 4928 4929 +1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/extern/CProducer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257/diff?src=pr&el=tree#diff-c3JjL2V4dGVybi9DUHJvZHVjZXIuY3Bw) | `42.69% <0%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=footer). Last update [b153039...fe7d173](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/257?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services