[PR] minor: remove AsyncResources#fromFutureCloseable (druid)

["clintropolis (via GitHub)" <gi...@apache.org>]

clintropolis opened a new pull request, #20356:
URL: https://github.com/apache/druid/pull/20356

   ### Description
   Follow-up to #20074, this PR removes `AsyncResources#fromFutureCloseable`, which isn't really safe for the whole reason `AsyncResource` exists in the first place (its hard/impossible to ensure that a closeable produced by a future is actually closed when strictly using futures). This method only had 1 caller, `StorageLocationVirtualStorageManager`, which now just populates a `SettableAsyncResource` directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

Re: [PR] minor: remove AsyncResources#fromFutureCloseable (druid)

["clintropolis (via GitHub)" <gi...@apache.org>]

clintropolis merged PR #20356:
URL: https://github.com/apache/druid/pull/20356


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org