You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/08 03:37:59 UTC
[GitHub] [incubator-seatunnel] hailin0 opened a new pull request, #2677: [Improve][e2e] Improved e2e start sleep
hailin0 opened a new pull request, #2677:
URL: https://github.com/apache/incubator-seatunnel/pull/2677
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Improved e2e start sleep
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2677: [Improve][e2e] Improved e2e start sleep
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2677:
URL: https://github.com/apache/incubator-seatunnel/pull/2677#discussion_r966716350
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/FakeSourceToJdbcIT.java:
##########
@@ -54,9 +57,11 @@ public void startPostgreSqlContainer() throws InterruptedException, ClassNotFoun
.withLogConsumer(new Slf4jLogConsumer(LOGGER));
Startables.deepStart(Stream.of(psl)).join();
LOGGER.info("PostgreSql container started");
- Thread.sleep(5000L);
Class.forName(psl.getDriverClassName());
- initializeJdbcTable();
+ given().ignoreExceptions()
+ .await()
+ .atMost(5, TimeUnit.SECONDS)
+ .untilAsserted(() -> initializeJdbcTable());
Review Comment:
How about adding a minimum wait time (ideally when the initialization completes short times), and then start polling until it succeeds or eventually fails or a timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin merged pull request #2677: [Improve][e2e] Improved e2e start sleep
Posted by GitBox <gi...@apache.org>.
ashulin merged PR #2677:
URL: https://github.com/apache/incubator-seatunnel/pull/2677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2677: [Improve][e2e] Improved e2e start sleep
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2677:
URL: https://github.com/apache/incubator-seatunnel/pull/2677#issuecomment-1240613381
why don't use api which is start()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2677: [Improve][e2e] Improved e2e start sleep
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2677:
URL: https://github.com/apache/incubator-seatunnel/pull/2677#issuecomment-1240659574
>  why don't use api which is start()
Just to unify with other testcase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2677: [Improve][e2e] Improved e2e start sleep
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2677:
URL: https://github.com/apache/incubator-seatunnel/pull/2677#issuecomment-1240785016
<img width="1754" alt="image" src="https://user-images.githubusercontent.com/14371345/189146664-0331347c-b369-4f03-8acd-66808f040a37.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2677: [Improve][e2e] Improved e2e start sleep
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2677:
URL: https://github.com/apache/incubator-seatunnel/pull/2677#issuecomment-1241913704
<img width="1760" alt="image" src="https://user-images.githubusercontent.com/14371345/189349243-da13e02c-35cb-4341-96ab-f46b25d0193a.png">
@ashulin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org