You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/01/21 10:24:13 UTC

[GitHub] [avro] RyanSkraba commented on pull request #1404: AVRO-3254: Automatically scale up or down decimal values when serializing

RyanSkraba commented on pull request #1404:
URL: https://github.com/apache/avro/pull/1404#issuecomment-1018375155


   Hello!  I have a quick concern about this PR -- modifying the scale of an AvroDecimal makes it no longer equal to its old value, so the serialize/deserialize would make the datum, or any record containing the datum (for example), no longer equal to its original value.
   
   I would be worried that this would have some unexpected side effects.  Any thoughts?
   
   We should take a look at what the other SDKs are doing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org