[GitHub] [incubator-doris] xinghuayu007 commented on pull request #5145: [Bug-Fix] Bucket shuffle join executes failed when two tables have no data

[GitBox <gi...@apache.org>]

xinghuayu007 commented on pull request #5145:
URL: https://github.com/apache/incubator-doris/pull/5145#issuecomment-751921532


   > I think it's little tricky here. It's the problem of left olap scan node with no data cause there is no tablet to decide where to sender the data. when left table is no data, FE should not chose the bucket shuffle join is better.
   > 
   > ```
   >         //1 the left table must be only one partition
   >         if (leftScanNode.getSelectedPartitionIds().size() != 1) {
   >             return false;
   >         }
   > ```
   
   good ideal. I will modify it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org