You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/12/24 00:41:54 UTC
[GitHub] [incubator-tvm] tqchen opened a new pull request #4578: [RUNTIME]
Remove Extension VTable in favor of Unified Object system.
tqchen opened a new pull request #4578: [RUNTIME] Remove Extension VTable in favor of Unified Object system.
URL: https://github.com/apache/incubator-tvm/pull/4578
Before the unified object protocol, we support pass
additional extension objects around by declaring a type as an extension type.
The old extension mechanism requires the types to register their
constructor and deleter to a VTable and does not enjoy the benefit of the
self-contained deletion property of the new Object system.
This PR upgrades the extension example to make use of the new object system
and removed the old Extension VTable.
Note that the register_extension funtion in the python side continues to work
when the passed argument does not require explicit container copy/deletion,
which covers the current usecases of the extension mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] junrushao1994 commented on issue #4578: [RUNTIME]
Remove Extension VTable in favor of Unified Object system.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on issue #4578: [RUNTIME] Remove Extension VTable in favor of Unified Object system.
URL: https://github.com/apache/incubator-tvm/pull/4578#issuecomment-568884077
Is this good to merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen merged pull request #4578: [RUNTIME] Remove
Extension VTable in favor of Unified Object system.
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4578: [RUNTIME] Remove Extension VTable in favor of Unified Object system.
URL: https://github.com/apache/incubator-tvm/pull/4578
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4578: [RUNTIME] Remove
Extension VTable in favor of Unified Object system.
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4578: [RUNTIME] Remove Extension VTable in favor of Unified Object system.
URL: https://github.com/apache/incubator-tvm/pull/4578#issuecomment-568615194
cc @junrushao1994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] junrushao1994 commented on issue #4578: [RUNTIME]
Remove Extension VTable in favor of Unified Object system.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on issue #4578: [RUNTIME] Remove Extension VTable in favor of Unified Object system.
URL: https://github.com/apache/incubator-tvm/pull/4578#issuecomment-568642078
Do we have a tutorial for this somewhere around? If so, shall we also delete this tutorial?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4578: [RUNTIME] Remove
Extension VTable in favor of Unified Object system.
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4578: [RUNTIME] Remove Extension VTable in favor of Unified Object system.
URL: https://github.com/apache/incubator-tvm/pull/4578#issuecomment-568653824
the example(apps/extension) has been updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #4578: [RUNTIME]
Remove Extension VTable in favor of Unified Object system.
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #4578: [RUNTIME] Remove Extension VTable in favor of Unified Object system.
URL: https://github.com/apache/incubator-tvm/pull/4578#issuecomment-568615194
cc @junrushao1994 @yzhliu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4578: [RUNTIME] Remove
Extension VTable in favor of Unified Object system.
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4578: [RUNTIME] Remove Extension VTable in favor of Unified Object system.
URL: https://github.com/apache/incubator-tvm/pull/4578#issuecomment-568615838
RFC https://github.com/apache/incubator-tvm/issues/4579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services