[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead

["Gustavo Anatoly (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573007#comment-13573007 ] 

Gustavo Anatoly commented on HBASE-7462:
----------------------------------------

Hi, Nicolas.

I tried mock a cluster, but my knowledge is limited yet I had some exceptions, so studying the TestAssigmentManager class I found this code:

{code}
  @BeforeClass
  public static void beforeClass() throws Exception {
    HTU.startMiniZKCluster();
  }

  @AfterClass
  public static void afterClass() throws IOException {
    HTU.shutdownMiniZKCluster();
  }
{code}

Can I use this stuff? Or I should mock ZooKeeper?

Thanks.
                
> TestDrainingServer is an integration test. It should be a unit test instead
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-7462
>                 URL: https://issues.apache.org/jira/browse/HBASE-7462
>             Project: HBase
>          Issue Type: Wish
>          Components: test
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Priority: Trivial
>              Labels: noob
>
> TestDrainingServer tests the function that allows to say that a regionserver should not get new regions.
> As it is written today, it's an integration test: it starts & stops a cluster.
> The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira