You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/16 11:10:21 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6682: Minor: combine `dataframe` and `dataframe_functions` tests to save build time and builder disk space

alamb commented on code in PR #6682:
URL: https://github.com/apache/arrow-datafusion/pull/6682#discussion_r1232110179


##########
datafusion/core/tests/dataframe.rs:
##########
@@ -1267,3 +1266,676 @@ async fn use_var_provider() -> Result<()> {
     dataframe.collect().await?;
     Ok(())
 }
+
+// --------------- Begin dataframe function tests ----------------

Review Comment:
   This is a good idea -- I implemented a modified version of this suggestion in https://github.com/apache/arrow-datafusion/pull/6697



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org