[GitHub] [airflow] samschlegel commented on a change in pull request #7428: [AIRFLOW-4526] Poll k8s logs to avoid problem with kubernetes logs --follow

[GitBox <gi...@apache.org>]

samschlegel commented on a change in pull request #7428: [AIRFLOW-4526] Poll k8s logs to avoid problem with kubernetes logs --follow
URL: https://github.com/apache/airflow/pull/7428#discussion_r379923324
 
 

 ##########
 File path: airflow/kubernetes/pod_launcher.py
 ##########
 @@ -162,22 +166,95 @@ def base_container_is_running(self, pod: V1Pod):
             return False
         return status.state.running is not None
 
+    @tenacity.retry(
+        stop=tenacity.stop_after_attempt(3),
+        wait=tenacity.wait_exponential(),
+        reraise=True,
+    )
+    def _read_pod_log_chunk(self, pod: V1Pod, last_line: bytes) -> HTTPResponse:
+        # The CoreV1Api doesn't support since_time even though the API does, so we must use
 
 Review comment:
   It's a limitation of the python module, but that's because for some reason they didn't include since_time in the API spec.
   
   The timestamp comes from the output of the kubernetes API and will always have a timestamp at the front no matter how many lines are printed or what the line content is

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services