You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/21 11:27:54 UTC
[GitHub] [doris] luozenglin opened a new pull request, #13558: [improvement](config) allow to modify the master-only configuration of non-master nodes
luozenglin opened a new pull request, #13558:
URL: https://github.com/apache/doris/pull/13558
Non-master nodes may switch to master, so we should allow the master-only configuration of all fe nodes to be modified.
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg merged pull request #13558: [improvement](config) allow to modify the master-only configuration of non-master nodes
Posted by GitBox <gi...@apache.org>.
yangzhg merged PR #13558:
URL: https://github.com/apache/doris/pull/13558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13558: [improvement](config) allow to modify the master-only configuration of non-master nodes
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13558:
URL: https://github.com/apache/doris/pull/13558#issuecomment-1287172888
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.7 seconds
load time: 567 seconds
storage size: 17154644812 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221022001411_clickbench_pr_32600.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13558: [improvement](config) allow to modify the master-only configuration of non-master nodes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13558:
URL: https://github.com/apache/doris/pull/13558#issuecomment-1287144655
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #13558: [improvement](config) allow to modify the master-only configuration of non-master nodes
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #13558:
URL: https://github.com/apache/doris/pull/13558#issuecomment-1287143436
> If this is a `master-only` config, can you modify it on non-master FE, the stmt will be forwarded to master, see the Constructor of `AdminSetConfigStmt`.
Oh, i see, this is only for `_set_config` api.
And for `admin set frontend config`, it still can only modify master config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13558: [improvement](config) allow to modify the master-only configuration of non-master nodes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13558:
URL: https://github.com/apache/doris/pull/13558#issuecomment-1287144601
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org