You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Ravinder Reddy (JIRA)" <ji...@apache.org> on 2007/07/23 23:35:32 UTC
[jira] Created: (DERBY-2968) convert lang/renameTable.sql to JUnit
convert lang/renameTable.sql to JUnit
-------------------------------------
Key: DERBY-2968
URL: https://issues.apache.org/jira/browse/DERBY-2968
Project: Derby
Issue Type: Test
Reporter: Ravinder Reddy
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2968) convert lang/renameTable.sql to JUnit
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren resolved DERBY-2968.
---------------------------------------
Resolution: Fixed
Fix Version/s: 10.4.1.3
looks like this was committed - 10.4.
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Fix For: 10.4.1.3
>
> Attachments: DERBY-2968.diff, DERBY-2968.diff.final, DERBY-2968.p3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2968) convert lang/renameTable.sql to JUnit
Posted by "Ravinder Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravinder Reddy updated DERBY-2968:
----------------------------------
Attachment: DERBY-2968.diff.final
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2968.diff, DERBY-2968.diff.final
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2968) convert lang/renameTable.sql to
JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518787 ]
Kathey Marsden commented on DERBY-2968:
---------------------------------------
I had some trouble applying the patch. Was this patch made against the trunk? Anyway I manually merged the changes, reformatted the new test, removed renameTable.sql from derbylang.runall and committed.
Kathey
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2968.diff, DERBY-2968.diff.final, DERBY-2968.p3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2968) convert lang/renameTable.sql to
JUnit
Posted by "Ravinder Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516243 ]
Ravinder Reddy commented on DERBY-2968:
---------------------------------------
1)
public void testRenameOpenCursoredTable() throws SQLException
{
Statement s = createStatement();
assertUpdateCount(s , 0 , "create table t2(c21 int not null primary key)");
assertUpdateCount(s , 1 , "insert into t2 values(21)");
assertUpdateCount(s , 1 , "insert into t2 values(22)");
//s.executeUpdate("get cursor c1 as 'select * from t2'");
//assertStatementError("X0X95" , s , "rename table t2 to fake");
}
I am getting syntax error in --- > get cursor c1 as 'select * from t2' statement.
plzz help me
Thank You
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2968.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2968) convert lang/renameTable.sql to JUnit
Posted by "Mike Matrigali (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Matrigali updated DERBY-2968:
----------------------------------
Component/s: Test
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2968.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2968) convert lang/renameTable.sql to
JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518527 ]
Kathey Marsden commented on DERBY-2968:
---------------------------------------
I looked at your new test and have the following comments:
- Can you change the test setup to not have assertions as recommended by Dan.
- Change the test to have space indentation instead of tabs and fix indentation to be consistent
- There is a typo, Bug 29994 instead of 2994.
- The new test needs to be added to lang/_Suite.java so it will run.
Maybe it would be good to name your patches v1,v2 etc instead of "final", just in case changes are needed.
Kathey
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2968.diff, DERBY-2968.diff.final
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2968) convert lang/renameTable.sql to
JUnit
Posted by "Ravinder Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516242 ]
Ravinder Reddy commented on DERBY-2968:
---------------------------------------
The patch is not ready for commit.
The test was successfully run on eclipse upon commenting two test cases.I will post the code for the 2 cases in my next comment.
any comments/suggestions/critics are highly appreciated.
P.S: I am on my way to write the comments.
Thank You.
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2968.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2968) convert lang/renameTable.sql to JUnit
Posted by "Ravinder Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravinder Reddy updated DERBY-2968:
----------------------------------
Attachment: DERBY-2968.p3
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2968.diff, DERBY-2968.diff.final, DERBY-2968.p3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2968) convert lang/renameTable.sql to
JUnit
Posted by "Ravinder Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518196 ]
Ravinder Reddy commented on DERBY-2968:
---------------------------------------
I hope it is ready for commit.
I commented a fixture with it's bug(issue) ID.
any comments/suggestions/critics are highly appreciated.
Thank You.
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2968.diff, DERBY-2968.diff.final
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2968) convert lang/renameTable.sql to
JUnit
Posted by "Ravinder Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518767 ]
Ravinder Reddy commented on DERBY-2968:
---------------------------------------
Thank You Kathey for your review/Suggestions.
Hope I made changes according to your specifications.
I am not sure about the space indentation issue as I manually indented.
please let me know if any Other changes are required.
Thank You.
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2968.diff, DERBY-2968.diff.final, DERBY-2968.p3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-2968) convert lang/renameTable.sql to JUnit
Posted by "Ravinder Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravinder Reddy reassigned DERBY-2968:
-------------------------------------
Assignee: Ravinder Reddy
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2968) convert lang/renameTable.sql to JUnit
Posted by "Ravinder Reddy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravinder Reddy updated DERBY-2968:
----------------------------------
Attachment: DERBY-2968.diff
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2968.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.