[jira] [Commented] (FLINK-5281) Extend KafkaJsonTableSources to support nested data

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823098#comment-15823098 ] 

ASF GitHub Bot commented on FLINK-5281:
---------------------------------------

GitHub user mushketyk opened a pull request:

    https://github.com/apache/flink/pull/3124

    [FLINK-5281] Extend KafkaJsonTableSources to support nested data

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    
    I've added support for serialization and deserialization of nested Rows in Json serializer/deserializer. I tried not to change interfaces, but I wonder if would make sense to replace all `String[] fieldNames, TypeInformation<?>[] fieldTypes` pairs with `RowTypeInfo`. This will change the interface (but we are doing this anyway) but will make interfaces clearer and will help to avoid some code duplication.
    @fhueske, what do you think about this?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mushketyk/flink json-nested-table-source

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3124
    
----
commit 3463919b94dd11796ad71d4983644322be38a209
Author: Ivan Mushketyk <iv...@gmail.com>
Date:   2017-01-14T14:33:51Z

    [FLINK-5281] Extend KafkaJsonTableSources to support nested data

----


> Extend KafkaJsonTableSources to support nested data
> ---------------------------------------------------
>
>                 Key: FLINK-5281
>                 URL: https://issues.apache.org/jira/browse/FLINK-5281
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Ivan Mushketyk
>
> The {{TableSource}} does currently not support nested data. 
> Once FLINK-5280 is fixed, the KafkaJsonTableSources should be extended to support nested input data. The nested data should be produced as {{Row}}s nested in {{Row}}s.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)