You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Chris Custine (JIRA)" <ji...@apache.org> on 2009/12/08 18:11:18 UTC
[jira] Created: (FELIX-1929) getStartLevel() always reports
requested start level, not active start level
getStartLevel() always reports requested start level, not active start level
----------------------------------------------------------------------------
Key: FELIX-1929
URL: https://issues.apache.org/jira/browse/FELIX-1929
Project: Felix
Issue Type: Bug
Components: Framework
Affects Versions: felix-2.0.2
Reporter: Chris Custine
Priority: Minor
Start Level spec for getStartLevel() states: "If the Framework is in the process of changing the start level this method must return the active start level if this differs from the requested start level."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1929) getStartLevel() always reports
requested start level, not active start level
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Custine updated FELIX-1929:
---------------------------------
Attachment: FELIX-1929.patch
> getStartLevel() always reports requested start level, not active start level
> ----------------------------------------------------------------------------
>
> Key: FELIX-1929
> URL: https://issues.apache.org/jira/browse/FELIX-1929
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.2
> Reporter: Chris Custine
> Assignee: Chris Custine
> Priority: Minor
> Attachments: FELIX-1929.patch
>
>
> Start Level spec for getStartLevel() states: "If the Framework is in the process of changing the start level this method must return the active start level if this differs from the requested start level."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1929) getStartLevel() always reports
requested start level, not active start level
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788147#action_12788147 ]
Richard S. Hall commented on FELIX-1929:
----------------------------------------
Ok, interpretation appears to be good. Feel free to commit, but please reformat to match the existing coding style (i.e., bracket placement on separate lines).
> getStartLevel() always reports requested start level, not active start level
> ----------------------------------------------------------------------------
>
> Key: FELIX-1929
> URL: https://issues.apache.org/jira/browse/FELIX-1929
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.2
> Reporter: Chris Custine
> Assignee: Chris Custine
> Priority: Minor
> Attachments: FELIX-1929.patch
>
>
> Start Level spec for getStartLevel() states: "If the Framework is in the process of changing the start level this method must return the active start level if this differs from the requested start level."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1929) getStartLevel() always reports
requested start level, not active start level
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787587#action_12787587 ]
Chris Custine commented on FELIX-1929:
--------------------------------------
Fix seems easy enough, I'll attach a patch here for review first.
> getStartLevel() always reports requested start level, not active start level
> ----------------------------------------------------------------------------
>
> Key: FELIX-1929
> URL: https://issues.apache.org/jira/browse/FELIX-1929
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.2
> Reporter: Chris Custine
> Assignee: Chris Custine
> Priority: Minor
>
> Start Level spec for getStartLevel() states: "If the Framework is in the process of changing the start level this method must return the active start level if this differs from the requested start level."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1929) getStartLevel() always reports
requested start level, not active start level
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787907#action_12787907 ]
Chris Custine commented on FELIX-1929:
--------------------------------------
This patch seems to do the the trick perfectly for me and both increments and decrements the active start level as it changes. I didn't see any point in incrementing by +1 when there are no bundles in that startlevel so I just inserted the increment/decrement inside the start/stop blocks. Those are already executed in proper order and have the only reference to what the current start level is (ie, start level of the current bundle).
Could one of the framework guys review this and let me know if this looks ok to commit?
> getStartLevel() always reports requested start level, not active start level
> ----------------------------------------------------------------------------
>
> Key: FELIX-1929
> URL: https://issues.apache.org/jira/browse/FELIX-1929
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.2
> Reporter: Chris Custine
> Assignee: Chris Custine
> Priority: Minor
> Attachments: FELIX-1929.patch
>
>
> Start Level spec for getStartLevel() states: "If the Framework is in the process of changing the start level this method must return the active start level if this differs from the requested start level."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1929) getStartLevel() always reports
requested start level, not active start level
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788145#action_12788145 ]
Richard S. Hall commented on FELIX-1929:
----------------------------------------
The patch looks ok...I will look into whether that is the correct interpretation of the spec.
You did not grant your patch for contribution, is that what you intended?
Thanks.
> getStartLevel() always reports requested start level, not active start level
> ----------------------------------------------------------------------------
>
> Key: FELIX-1929
> URL: https://issues.apache.org/jira/browse/FELIX-1929
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.2
> Reporter: Chris Custine
> Assignee: Chris Custine
> Priority: Minor
> Attachments: FELIX-1929.patch
>
>
> Start Level spec for getStartLevel() states: "If the Framework is in the process of changing the start level this method must return the active start level if this differs from the requested start level."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1929) getStartLevel() always reports
requested start level, not active start level
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Custine resolved FELIX-1929.
----------------------------------
Resolution: Fixed
Thanks for reviewing the patch Richard. I fixed the code formatting and committed. I attached the original patch from a plugin in my IDE and it didn't show the ASF Grant custom field so I'll have to remember that next time.
> getStartLevel() always reports requested start level, not active start level
> ----------------------------------------------------------------------------
>
> Key: FELIX-1929
> URL: https://issues.apache.org/jira/browse/FELIX-1929
> Project: Felix
> Issue Type: Bug
> Components: Framework, Specification compliance
> Affects Versions: felix-2.0.2
> Reporter: Chris Custine
> Assignee: Chris Custine
> Priority: Minor
> Fix For: felix-2.2.0
>
> Attachments: FELIX-1929.patch
>
>
> Start Level spec for getStartLevel() states: "If the Framework is in the process of changing the start level this method must return the active start level if this differs from the requested start level."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1929) getStartLevel() always reports
requested start level, not active start level
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall updated FELIX-1929:
-----------------------------------
Component/s: Specification compliance
Fix Version/s: felix-2.2.0
> getStartLevel() always reports requested start level, not active start level
> ----------------------------------------------------------------------------
>
> Key: FELIX-1929
> URL: https://issues.apache.org/jira/browse/FELIX-1929
> Project: Felix
> Issue Type: Bug
> Components: Framework, Specification compliance
> Affects Versions: felix-2.0.2
> Reporter: Chris Custine
> Assignee: Chris Custine
> Priority: Minor
> Fix For: felix-2.2.0
>
> Attachments: FELIX-1929.patch
>
>
> Start Level spec for getStartLevel() states: "If the Framework is in the process of changing the start level this method must return the active start level if this differs from the requested start level."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1929) getStartLevel() always reports
requested start level, not active start level
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Custine updated FELIX-1929:
---------------------------------
Assignee: Chris Custine
> getStartLevel() always reports requested start level, not active start level
> ----------------------------------------------------------------------------
>
> Key: FELIX-1929
> URL: https://issues.apache.org/jira/browse/FELIX-1929
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-2.0.2
> Reporter: Chris Custine
> Assignee: Chris Custine
> Priority: Minor
>
> Start Level spec for getStartLevel() states: "If the Framework is in the process of changing the start level this method must return the active start level if this differs from the requested start level."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.