You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/03 14:31:01 UTC

[GitHub] [iceberg] Fokko opened a new pull request, #6114: Python: Use Types from Typing

Fokko opened a new pull request, #6114:
URL: https://github.com/apache/iceberg/pull/6114

   Instead of using the runtime types that are available using the futures import:
   
   ```python
   from __future__ import annotations
   ```
   
   I prefer to use the types from Typing:
   
   - I think `Optional[str]` is clearer than `str | None`.
   - Not all types are available, so we have to import from Types anyway (typevar, Callable, etc)
   
   PyUpgrade was rewriting the [imports automatically](https://github.com/asottile/pyupgrade#pep-585-typing-rewrites), so we ended up with a mix, but I think it is better to stay consistent. I've disabled this on PyUpgrade.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue merged pull request #6114: Python: Use Types from Typing

Posted by GitBox <gi...@apache.org>.
rdblue merged PR #6114:
URL: https://github.com/apache/iceberg/pull/6114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #6114: Python: Use Types from Typing

Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #6114:
URL: https://github.com/apache/iceberg/pull/6114#issuecomment-1302456665

   Thanks, @Fokko!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org