You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/03/31 14:23:12 UTC
[PR] fix issue with forkjoin [pekko]
pjfanning opened a new pull request, #1245:
URL: https://github.com/apache/pekko/pull/1245
relates to #485
The method handle seemed to work in my testing but today, I am seeing issues.
This change fixes the issues I have seen.
This was the exception I got and that no longer happens with this PR change.
```
[error] java.lang.invoke.WrongMethodTypeException: expected (int,ForkJoinWorkerThreadFactory,int,UncaughtExceptionHandler,boolean)PekkoJdk9ForkJoinPool but found (int,ForkJoinWorkerThreadFactory,int,UncaughtExceptionHandler,boolean)Object
[error] at java.base/java.lang.invoke.Invokers.newWrongMethodTypeException(Invokers.java:476)
[error] at java.base/java.lang.invoke.Invokers.checkExactType(Invokers.java:485)
[error] at org.apache.pekko.dispatch.ForkJoinExecutorConfigurator$ForkJoinExecutorServiceFactory.createExecutorService(ForkJoinExecutorConfigurator.scala:122)
[error] at org.apache.pekko.dispatch.Dispatcher$LazyExecutorServiceDelegate.executor$lzycompute(Dispatcher.scala:54)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix issue with forkjoin [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1245:
URL: https://github.com/apache/pekko/pull/1245#issuecomment-2028828374
Great, as the invoke will do type conversations when type not match exactly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix issue with forkjoin [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1245:
URL: https://github.com/apache/pekko/pull/1245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix issue with forkjoin [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1245:
URL: https://github.com/apache/pekko/pull/1245#issuecomment-2028828782
> Great, as the invoke will do type conversations when type not match exactly
I rarely find that invokeExact actually works. I'm finding in most cases that I need to use invoke anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org