[jira] [Commented] (BOOKKEEPER-582) Make bookie and client use protobuf for requests (non-wire part)

["Ivan Kelly (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619686#comment-13619686 ] 

Ivan Kelly commented on BOOKKEEPER-582:
---------------------------------------

This would mean modifying BookieClient methods any time we need to add something to the protocol, which may mean the method name would get very long. I'd like to actually go in the opposite direction, where addEntry and readEntry get merged and replaced with Bookie#sendRequest() which takes a BookkeeperProtocol.Request object and the protocol knows nothing of the actual meaning of the request. This requires transaction ids, which I plan to pull in in a later patch. It may be that we need to keep addEntry and readEntry for BC reasons, but I'd like to move as much towards the idea I outlines as possible.
                
> Make bookie and client use protobuf for requests (non-wire part)
> ----------------------------------------------------------------
>
>                 Key: BOOKKEEPER-582
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-582
>             Project: Bookkeeper
>          Issue Type: Sub-task
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.3.0
>
>         Attachments: 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch, 0003-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch
>
>
> Make the client and the bookie use protobufs internally. This is the first step to using protobufs on the wire, but for the moment, BookieRequestHandler decodes the old wire protocol into the protobuf messages. Once this is in, enabling on the wire will be very simple, and the old manual serialization can be made "legacy" (still supported, but deprecated).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira