You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "jgoz (via GitHub)" <gi...@apache.org> on 2023/03/15 15:58:21 UTC
[GitHub] [druid] jgoz opened a new pull request, #13937: Dart sass
jgoz opened a new pull request, #13937:
URL: https://github.com/apache/druid/pull/13937
### Description
Switch to Dart Sass so that the web console can be compiled on Mac arm64 architectures.
This necessitated two changes:
- Shim the `svg-icons` function because we don't have access to it. Apparently [it's possible to use from Blueprint's build system](https://github.com/palantir/blueprint/issues/5334#issuecomment-1444223876) but this also requires copying the icon SVG files into the repo since they're not included in npm. It was simpler to render `transparent` for these, since the function was only being used for breadcrumbs and the Web Console doesn't use Blueprint's breadcrumbs (AFAIK)
- Upgrade Blueprint to pull in [these changes](https://github.com/palantir/blueprint/pull/5216) that make its scss source compatible with Dart Sass
I also ran `sass-migrator` to clean up deprecated syntax in our local scss files.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #13937: Dart sass
Posted by "vogievetsky (via GitHub)" <gi...@apache.org>.
vogievetsky merged PR #13937:
URL: https://github.com/apache/druid/pull/13937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org