You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/05/10 15:47:31 UTC
[GitHub] [incubator-opendal] Xuanwo opened a new pull request, #2251: docs: Add services in readme
Xuanwo opened a new pull request, #2251:
URL: https://github.com/apache/incubator-opendal/pull/2251
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] PsiACE merged pull request #2251: docs: Add services in readme
Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE merged PR #2251:
URL: https://github.com/apache/incubator-opendal/pull/2251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #2251: docs: Add services in readme
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #2251:
URL: https://github.com/apache/incubator-opendal/pull/2251#discussion_r1190193707
##########
README.md:
##########
@@ -28,6 +28,37 @@ Major components of the project include:
- [oli](bin/oli): OpenDAL Command Line Interface
- [oay](bin/oay): OpenDAL Gateway
+**Services**
+
Review Comment:
We may also add a brief introduction about services here.(Or a link to docs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2251: docs: Add services in readme
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2251:
URL: https://github.com/apache/incubator-opendal/pull/2251#discussion_r1190141734
##########
README.md:
##########
@@ -28,6 +28,37 @@ Major components of the project include:
- [oli](bin/oli): OpenDAL Command Line Interface
- [oay](bin/oay): OpenDAL Gateway
+**Services**
+
Review Comment:
> It would probably be better to list the general backend and the kv backend separately.
Why? OpenDAL users shouldn't care about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] PsiACE commented on a diff in pull request #2251: docs: Add services in readme
Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE commented on code in PR #2251:
URL: https://github.com/apache/incubator-opendal/pull/2251#discussion_r1190116736
##########
README.md:
##########
@@ -28,6 +28,37 @@ Major components of the project include:
- [oli](bin/oli): OpenDAL Command Line Interface
- [oay](bin/oay): OpenDAL Gateway
+**Services**
+
Review Comment:
Also this will be a relatively long list, I personally tend to list a few of the main ones and then fold the rest using `<details close><summary></summary></details>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2251: docs: Add services in readme
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2251:
URL: https://github.com/apache/incubator-opendal/pull/2251#discussion_r1190142226
##########
README.md:
##########
@@ -28,6 +28,37 @@ Major components of the project include:
- [oli](bin/oli): OpenDAL Command Line Interface
- [oay](bin/oay): OpenDAL Gateway
+**Services**
+
Review Comment:
> Also this will be a relatively long list, I personally tend to list a few of the main ones and then fold the rest using `<details close><summary></summary></details>`.
Since it's bot long enough, let's list them all AS-IS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2251: docs: Add services in readme
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2251:
URL: https://github.com/apache/incubator-opendal/pull/2251#issuecomment-1543045285
cc @PsiACE @suyanhanx, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2251: docs: Add services in readme
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2251:
URL: https://github.com/apache/incubator-opendal/pull/2251#discussion_r1190149687
##########
README.md:
##########
@@ -28,6 +28,37 @@ Major components of the project include:
- [oli](bin/oli): OpenDAL Command Line Interface
- [oay](bin/oay): OpenDAL Gateway
+**Services**
+
Review Comment:
> Since it's bot long enough, let's list them all AS-IS. They are OpenDAL's strength.
Maybe we can have a better organizations, let me take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] PsiACE commented on a diff in pull request #2251: docs: Add services in readme
Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE commented on code in PR #2251:
URL: https://github.com/apache/incubator-opendal/pull/2251#discussion_r1190112998
##########
README.md:
##########
@@ -28,6 +28,37 @@ Major components of the project include:
- [oli](bin/oli): OpenDAL Command Line Interface
- [oay](bin/oay): OpenDAL Gateway
+**Services**
+
Review Comment:
It would probably be better to list the general backend and the kv backend separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2251: docs: Add services in readme
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2251:
URL: https://github.com/apache/incubator-opendal/pull/2251#discussion_r1190142226
##########
README.md:
##########
@@ -28,6 +28,37 @@ Major components of the project include:
- [oli](bin/oli): OpenDAL Command Line Interface
- [oay](bin/oay): OpenDAL Gateway
+**Services**
+
Review Comment:
> Also this will be a relatively long list, I personally tend to list a few of the main ones and then fold the rest using `<details close><summary></summary></details>`.
Since it's bot long enough, let's list them all AS-IS. They are OpenDAL's strength.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2251: docs: Add services in readme
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2251:
URL: https://github.com/apache/incubator-opendal/pull/2251#discussion_r1190211027
##########
README.md:
##########
@@ -28,6 +28,37 @@ Major components of the project include:
- [oli](bin/oli): OpenDAL Command Line Interface
- [oay](bin/oay): OpenDAL Gateway
+**Services**
+
Review Comment:
> We may also add a brief introduction about services here.(Or a link to docs)
This is the README for OpenDAL project so we should not link to rust core's docs. We just let users know OpenDAL supports the following services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org