You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LucaCappelletti94 (via GitHub)" <gi...@apache.org> on 2025/09/07 10:02:40 UTC
[I] Moving `CreateTrigger` variant of `Statement` into its own struct [datafusion-sqlparser-rs]
LucaCappelletti94 opened a new issue, #2022:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2022
Hi - I plan to extend the support of SQLite in the current implementation of `CreateTrigger`, which [I had originally implemented only for the Postgres syntax](https://github.com/apache/datafusion-sqlparser-rs/pull/1352) to address issues such as https://github.com/apache/datafusion-sqlparser-rs/issues/1388 and https://github.com/takluyver/sqlite-glance/issues/1.
Before doing that, I wanted to refactor it into its own struct, as it would make it more manageable and I seem to understand it is a desirable refactoring for the crate.
Let me know whether to proceed with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Moving `CreateTrigger` variant of `Statement` into its own struct [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on issue #2022:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2022#issuecomment-3270935178
Yeah I think this would be a desirable change, we have a [tracking issue here](https://github.com/apache/datafusion-sqlparser-rs/issues/1204) to gradually make our way through the existing statements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Moving `CreateTrigger` variant of `Statement` into its own struct [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on issue #2022:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2022#issuecomment-3268967672
@iffyio could you kindly lmk your opinion on the matter here as well before I start a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Moving `CreateTrigger` variant of `Statement` into its own struct [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 closed issue #2022: Moving `CreateTrigger` variant of `Statement` into its own struct
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org