[GitHub] nickva commented on a change in pull request #862: [WIP] Configurably whitelist certain db/docids as valid

[gi...@git.apache.org]

nickva commented on a change in pull request #862: [WIP] Configurably whitelist certain db/docids as valid
URL: https://github.com/apache/couchdb/pull/862#discussion_r142310651
 
 

 ##########
 File path: rel/overlay/etc/default.ini
 ##########
 @@ -49,9 +49,12 @@ changes_doc_ids_optimization_threshold = 100
 ; applied conservatively. For example 1.0e+16 could be encoded as 1e16, so 4 used
 ; for size calculation instead of 7.
 ;max_document_size = 4294967296 ; bytes
-
 ; Maximum attachment size.
 ; max_attachment_size = infinity
+;
+; Whitelisted reserved document names (to allow modification of shard maps)
+; List of tuples of the form {dbname, [docid, ...]}
+;whitelist_doc_ids = [{"_dbs", ["_users", "_replicator", "_global_changes"]}]
 
 Review comment:
   Technically dbs is already a configured parameter, `mem3.shards_db` I believe,  maybe just read `config:get("mem3", "shards_db", "_dbs")` when validating.
   
   _replicator is a hard-coded maybe we don't need it to be configurable.  `_users` is from `chttpd_auth.authentication_db` so there can read from config and `_global_changes` I think is also hard coded like replicator.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services