You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2021/01/28 11:54:19 UTC

[GitHub] [openmeetings] ali-alhaidary commented on a change in pull request #122: Update languages.xml

ali-alhaidary commented on a change in pull request #122:
URL: https://github.com/apache/openmeetings/pull/122#discussion_r566035103



##########
File path: openmeetings-web/src/main/webapp/languages/languages.xml
##########
@@ -32,7 +32,7 @@
 	<lang id="11" code="zh-CN" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese simplified</lang>
 	<lang id="12" code="zh-TW" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese traditional</lang>
 	<lang id="13" code="ko" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">korean</lang>
-	<lang id="14" code="ar" tip="Only capital Latin latters A-Z" rangeStart="ا" rangeEnd="غ">arabic</lang>
+	<lang id="14" code="ar" tip="ادخل الرمز هنا" rangeStart="1" rangeEnd="9">عربي</lang>

Review comment:
       > @ali-alhaidary Are you sure the range is correct?
   > I have used your previous range: 0627-063A ....
   The range given before is correct, however, after few attempts (with
   moodle new registrations as well) we found out that RTL letters become
   very confusing especially many of them have dots غ ع ق ف ج ح خ ض ص that
   makes even harder to see, so we agreed that numerals 1-9 (we excluded
   zero as well) are our best chose for all RTL that we use (and all of our
   users are RTL), but you can put the older range as standard, and we
   customize it locally.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org