[jira] [Resolved] (OAK-7853) SegmentBufferWriter not flushed after OnRC

["Michael Dürig (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig resolved OAK-7853.
--------------------------------
    Resolution: Fixed

Thanks for the review [~frm]

Fixed at [http://svn.apache.org/viewvc?rev=1844549&view=rev]

 

> SegmentBufferWriter not flushed after OnRC
> ------------------------------------------
>
>                 Key: OAK-7853
>                 URL: https://issues.apache.org/jira/browse/OAK-7853
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>            Priority: Major
>              Labels: candidate_oak_1_6, candidate_oak_1_8
>             Fix For: 1.10
>
>
> I suspect there is a rare case where a {{SegmentBufferWriter}} is not flushed from the {{SegmentBufferWriterPool}}. This would happen after OnRC when a previous writer is [disposed|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentBufferWriterPool.java#L194] (vs. being re-used). AFAIU this currently those writers would never be flushed any more and thus lose their transient segment when the store is shut down. This will lead to an inconsistent store ({{SNFE}}).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)