You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2010/02/25 23:09:28 UTC
[jira] Created: (PIG-1261) PigStorageSchema broke after changes to
ResourceSchema
PigStorageSchema broke after changes to ResourceSchema
------------------------------------------------------
Key: PIG-1261
URL: https://issues.apache.org/jira/browse/PIG-1261
Project: Pig
Issue Type: Bug
Components: impl
Affects Versions: 0.7.0
Reporter: Daniel Dai
Assignee: Dmitriy V. Ryaboy
Fix For: 0.7.0
After we add a new method "getCastString" into ResourceSchema, TestPigStorageSchema begin to fail. Seems PigStorageSchema try to serialize cast string into the schema. If I change the name of the method from "getCastString" to "genCastString", then the error message go away. Since Dmitriy is the author of TestPigStorageSchema, I need his help to check if this is the right approach to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1261) PigStorageSchema broke after changes to
ResourceSchema
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1261:
----------------------------
Attachment: TestPigStorageSchema.java
BTW, TestPigStorageSchema is temporarily removed. I attached original code in the Jira.
> PigStorageSchema broke after changes to ResourceSchema
> ------------------------------------------------------
>
> Key: PIG-1261
> URL: https://issues.apache.org/jira/browse/PIG-1261
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.7.0
>
> Attachments: TestPigStorageSchema.java
>
>
> After we add a new method "getCastString" into ResourceSchema, TestPigStorageSchema begin to fail. Seems PigStorageSchema try to serialize cast string into the schema. If I change the name of the method from "getCastString" to "genCastString", then the error message go away. Since Dmitriy is the author of TestPigStorageSchema, I need his help to check if this is the right approach to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (PIG-1261) PigStorageSchema broke after changes to
ResourceSchema
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai closed PIG-1261.
---------------------------
> PigStorageSchema broke after changes to ResourceSchema
> ------------------------------------------------------
>
> Key: PIG-1261
> URL: https://issues.apache.org/jira/browse/PIG-1261
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.7.0
>
> Attachments: PIG_1261.diff, TestPigStorageSchema.java
>
>
> After we add a new method "getCastString" into ResourceSchema, TestPigStorageSchema begin to fail. Seems PigStorageSchema try to serialize cast string into the schema. If I change the name of the method from "getCastString" to "genCastString", then the error message go away. Since Dmitriy is the author of TestPigStorageSchema, I need his help to check if this is the right approach to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1261) PigStorageSchema broke after changes to
ResourceSchema
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1261:
--------------------------------
Status: Patch Available (was: Open)
> PigStorageSchema broke after changes to ResourceSchema
> ------------------------------------------------------
>
> Key: PIG-1261
> URL: https://issues.apache.org/jira/browse/PIG-1261
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.7.0
>
> Attachments: PIG_1261.diff, TestPigStorageSchema.java
>
>
> After we add a new method "getCastString" into ResourceSchema, TestPigStorageSchema begin to fail. Seems PigStorageSchema try to serialize cast string into the schema. If I change the name of the method from "getCastString" to "genCastString", then the error message go away. Since Dmitriy is the author of TestPigStorageSchema, I need his help to check if this is the right approach to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1261) PigStorageSchema broke after changes
to ResourceSchema
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838587#action_12838587 ]
Dmitriy V. Ryaboy commented on PIG-1261:
----------------------------------------
I'll check it out.
> PigStorageSchema broke after changes to ResourceSchema
> ------------------------------------------------------
>
> Key: PIG-1261
> URL: https://issues.apache.org/jira/browse/PIG-1261
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.7.0
>
> Attachments: TestPigStorageSchema.java
>
>
> After we add a new method "getCastString" into ResourceSchema, TestPigStorageSchema begin to fail. Seems PigStorageSchema try to serialize cast string into the schema. If I change the name of the method from "getCastString" to "genCastString", then the error message go away. Since Dmitriy is the author of TestPigStorageSchema, I need his help to check if this is the right approach to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1261) PigStorageSchema broke after changes to
ResourceSchema
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1261:
----------------------------
Resolution: Fixed
Release Note: Patch committed. Thanks Dmitriy!
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
> PigStorageSchema broke after changes to ResourceSchema
> ------------------------------------------------------
>
> Key: PIG-1261
> URL: https://issues.apache.org/jira/browse/PIG-1261
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.7.0
>
> Attachments: PIG_1261.diff, TestPigStorageSchema.java
>
>
> After we add a new method "getCastString" into ResourceSchema, TestPigStorageSchema begin to fail. Seems PigStorageSchema try to serialize cast string into the schema. If I change the name of the method from "getCastString" to "genCastString", then the error message go away. Since Dmitriy is the author of TestPigStorageSchema, I need his help to check if this is the right approach to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1261) PigStorageSchema broke after changes to
ResourceSchema
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-1261:
-----------------------------------
Attachment: PIG_1261.diff
The json reflection PigStorageSchema is using to auto-serialize and deserialize assumes things about methods that start with set and get. I renamed the methods.
That's not a good solution, but it's a fast one.
> PigStorageSchema broke after changes to ResourceSchema
> ------------------------------------------------------
>
> Key: PIG-1261
> URL: https://issues.apache.org/jira/browse/PIG-1261
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.7.0
>
> Attachments: PIG_1261.diff, TestPigStorageSchema.java
>
>
> After we add a new method "getCastString" into ResourceSchema, TestPigStorageSchema begin to fail. Seems PigStorageSchema try to serialize cast string into the schema. If I change the name of the method from "getCastString" to "genCastString", then the error message go away. Since Dmitriy is the author of TestPigStorageSchema, I need his help to check if this is the right approach to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1261) PigStorageSchema broke after changes
to ResourceSchema
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841136#action_12841136 ]
Hadoop QA commented on PIG-1261:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12437156/PIG_1261.diff
against trunk revision 917827.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/233/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/233/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/233/console
This message is automatically generated.
> PigStorageSchema broke after changes to ResourceSchema
> ------------------------------------------------------
>
> Key: PIG-1261
> URL: https://issues.apache.org/jira/browse/PIG-1261
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.7.0
>
> Attachments: PIG_1261.diff, TestPigStorageSchema.java
>
>
> After we add a new method "getCastString" into ResourceSchema, TestPigStorageSchema begin to fail. Seems PigStorageSchema try to serialize cast string into the schema. If I change the name of the method from "getCastString" to "genCastString", then the error message go away. Since Dmitriy is the author of TestPigStorageSchema, I need his help to check if this is the right approach to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.