You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Devdeep Singh <de...@citrix.com> on 2012/08/31 18:29:22 UTC

Review Request: Removing the older xenapi jar and adding an ant target to build one from the source

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6873/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

Removing the older xenapi jar and adding an ant target to build one from the source.


Diffs
-----

  build/build-cloud.xml 2ad3715 
  cloud.spec 0670ec6 
  deps/.classpath 1376b4f 
  deps/cloud-xenserver-5.6.100-1.jar ff3744fa9d813a9580d616147ce71d69ba2dc845 

Diff: https://reviews.apache.org/r/6873/diff/


Testing
-------

ant clean-all compile-server
ant clean-all build-all


Thanks,

Devdeep Singh


Re: Review Request: Removing the older xenapi jar and adding an ant target to build one from the source

Posted by anthony xu <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6873/#review11191
-----------------------------------------------------------

Ship it!


Ship It!

- anthony xu


On Aug. 31, 2012, 4:29 p.m., Devdeep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6873/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2012, 4:29 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Removing the older xenapi jar and adding an ant target to build one from the source.
> 
> 
> Diffs
> -----
> 
>   build/build-cloud.xml 2ad3715 
>   cloud.spec 0670ec6 
>   deps/.classpath 1376b4f 
>   deps/cloud-xenserver-5.6.100-1.jar ff3744fa9d813a9580d616147ce71d69ba2dc845 
> 
> Diff: https://reviews.apache.org/r/6873/diff/
> 
> 
> Testing
> -------
> 
> ant clean-all compile-server
> ant clean-all build-all
> 
> 
> Thanks,
> 
> Devdeep Singh
> 
>


Re: Review Request: Removing the older xenapi jar and adding an ant target to build one from the source

Posted by anthony xu <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6873/#review11347
-----------------------------------------------------------

Ship it!


Ship It!

- anthony xu


On Aug. 31, 2012, 4:29 p.m., Devdeep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6873/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2012, 4:29 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Removing the older xenapi jar and adding an ant target to build one from the source.
> 
> 
> Diffs
> -----
> 
>   build/build-cloud.xml 2ad3715 
>   cloud.spec 0670ec6 
>   deps/.classpath 1376b4f 
>   deps/cloud-xenserver-5.6.100-1.jar ff3744fa9d813a9580d616147ce71d69ba2dc845 
> 
> Diff: https://reviews.apache.org/r/6873/diff/
> 
> 
> Testing
> -------
> 
> ant clean-all compile-server
> ant clean-all build-all
> 
> 
> Thanks,
> 
> Devdeep Singh
> 
>


Re: Review Request: Removing the older xenapi jar and adding an ant target to build one from the source

Posted by David Nalley <da...@gnsa.us>.

> On Sept. 8, 2012, 12:03 a.m., edison su wrote:
> > Why still need it? maven will automatically download xapi jar into deps folder.

It shouldn't - we depend on specific things in our fork of Xenserver-java. IIRC there's a maven build target (sorry, I know that's ant terminology) to build Xenserver java from source in deps. 

--David


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6873/#review11193
-----------------------------------------------------------


On Aug. 31, 2012, 4:29 p.m., Devdeep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6873/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2012, 4:29 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Removing the older xenapi jar and adding an ant target to build one from the source.
> 
> 
> Diffs
> -----
> 
>   build/build-cloud.xml 2ad3715 
>   cloud.spec 0670ec6 
>   deps/.classpath 1376b4f 
>   deps/cloud-xenserver-5.6.100-1.jar ff3744fa9d813a9580d616147ce71d69ba2dc845 
> 
> Diff: https://reviews.apache.org/r/6873/diff/
> 
> 
> Testing
> -------
> 
> ant clean-all compile-server
> ant clean-all build-all
> 
> 
> Thanks,
> 
> Devdeep Singh
> 
>


Re: Review Request: Removing the older xenapi jar and adding an ant target to build one from the source

Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6873/#review11193
-----------------------------------------------------------


Why still need it? maven will automatically download xapi jar into deps folder.

- edison su


On Aug. 31, 2012, 4:29 p.m., Devdeep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6873/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2012, 4:29 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Removing the older xenapi jar and adding an ant target to build one from the source.
> 
> 
> Diffs
> -----
> 
>   build/build-cloud.xml 2ad3715 
>   cloud.spec 0670ec6 
>   deps/.classpath 1376b4f 
>   deps/cloud-xenserver-5.6.100-1.jar ff3744fa9d813a9580d616147ce71d69ba2dc845 
> 
> Diff: https://reviews.apache.org/r/6873/diff/
> 
> 
> Testing
> -------
> 
> ant clean-all compile-server
> ant clean-all build-all
> 
> 
> Thanks,
> 
> Devdeep Singh
> 
>