You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Fine0830 (via GitHub)" <gi...@apache.org> on 2026/02/04 02:41:07 UTC
[PR] Update flags for the fodc agent [skywalking-banyandb-helm]
Fine0830 opened a new pull request, #51:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/51
Adds `cluster-state-ports` and remove `node-role` for the fodc agent.
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update flags for the fodc agent [skywalking-banyandb-helm]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #51:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update flags for the fodc agent [skywalking-banyandb-helm]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #51:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/51#discussion_r2762952958
##########
chart/templates/standalone_statefulset.yaml:
##########
@@ -248,7 +248,6 @@ spec:
- --proxy-addr={{ template "banyandb.fullname" . }}-fodc-proxy-grpc:{{ .Values.cluster.fodc.proxy.grpcSvc.port }} \
- --pod-name=$(POD_NAME)
- --container-names=standalone
- - --node-role=standalone
- --poll-metrics-ports=2121
- --poll-metrics-interval={{ .Values.cluster.fodc.agent.config.pollMetricsInterval }}
Review Comment:
The standalone fodc-agent is missing the cluster-state-ports flag and cluster-state-poll-interval flag that are being added to liaison and data agents. Since the standalone container exposes port 17912 (gRPC) which provides cluster state information, the fodc-agent should include these flags to monitor cluster state. Consider adding:
- --cluster-state-ports=17912
- --cluster-state-poll-interval={{ .Values.cluster.fodc.agent.config.pollClusterStateInterval }}
```suggestion
- --poll-metrics-interval={{ .Values.cluster.fodc.agent.config.pollMetricsInterval }}
- --cluster-state-ports=17912
- --cluster-state-poll-interval={{ .Values.cluster.fodc.agent.config.pollClusterStateInterval }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update flags for the fodc agent [skywalking-banyandb-helm]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #51:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/51#discussion_r2763085393
##########
chart/values.yaml:
##########
@@ -994,6 +994,8 @@ cluster:
reconnectInterval: 10s
## @param cluster.fodc.agent.config.ktmEnabled Enable Kernel Telemetry Module (affects max-metrics-memory-usage-percentage)
ktmEnabled: true
+ ## @param cluster.fodc.agent.config.pollClusterStateInterval Interval for polling cluster state from Proxy (poll-cluster-state-interval flag)
+ pollClusterStateInterval: 30s
Review Comment:
Update parameters.md since a new parameter has been introduced.
##########
chart/templates/standalone_statefulset.yaml:
##########
@@ -248,7 +248,6 @@ spec:
- --proxy-addr={{ template "banyandb.fullname" . }}-fodc-proxy-grpc:{{ .Values.cluster.fodc.proxy.grpcSvc.port }} \
- --pod-name=$(POD_NAME)
- --container-names=standalone
- - --node-role=standalone
- --poll-metrics-ports=2121
- --poll-metrics-interval={{ .Values.cluster.fodc.agent.config.pollMetricsInterval }}
Review Comment:
It makes sense. Please fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org