You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/19 09:13:20 UTC
[GitHub] [kafka] jlprat opened a new pull request #10724: KAFKA-12808: Remove Deprecated Methods under StreamsMetrics
jlprat opened a new pull request #10724:
URL: https://github.com/apache/kafka/pull/10724
Removal of methods already deprecated since 2.5.
Adapt test to use the new alternative method.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat edited a comment on pull request #10724: KAFKA-12808: Remove Deprecated Methods under StreamsMetrics
Posted by GitBox <gi...@apache.org>.
jlprat edited a comment on pull request #10724:
URL: https://github.com/apache/kafka/pull/10724#issuecomment-845226161
Fixed pushed, `@SuppressWarnings("deprecation")` is now removed, Feel free to review @cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10724: KAFKA-12808: Remove Deprecated Methods under StreamsMetrics
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10724:
URL: https://github.com/apache/kafka/pull/10724#issuecomment-845846625
Tests are now not passing, but they seem all unrelated to the change itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10724: KAFKA-12808: Remove Deprecated Methods under StreamsMetrics
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10724:
URL: https://github.com/apache/kafka/pull/10724#issuecomment-845750920
Restarted the build since the JDK 11 build failed with
```
Process 'Gradle Test Executor 123' finished with non-zero exit value 143
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10724: KAFKA-12808: Remove Deprecated Methods under StreamsMetrics
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10724:
URL: https://github.com/apache/kafka/pull/10724#issuecomment-845856403
Test failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a change in pull request #10724: KAFKA-12808: Remove Deprecated Methods under StreamsMetrics
Posted by GitBox <gi...@apache.org>.
cadonna commented on a change in pull request #10724:
URL: https://github.com/apache/kafka/pull/10724#discussion_r636167629
##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java
##########
@@ -777,12 +777,12 @@ public void testLatencyMetrics() {
final String entity = "entity";
final String operation = "put";
- final Sensor sensor1 = streamsMetrics.addLatencyAndThroughputSensor(scope, entity, operation, RecordingLevel.DEBUG);
Review comment:
You can also remove the `@SuppressWarnings("deprecation")` at the top of the method.
##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java
##########
@@ -797,11 +797,11 @@ public void testThroughputMetrics() {
final String entity = "entity";
final String operation = "put";
- final Sensor sensor1 = streamsMetrics.addThroughputSensor(scope, entity, operation, RecordingLevel.DEBUG);
Review comment:
You can also remove the `@SuppressWarnings("deprecation")` at the top of the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10724: KAFKA-12808: Remove Deprecated Methods under StreamsMetrics
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10724:
URL: https://github.com/apache/kafka/pull/10724#issuecomment-845226161
Fixed pushed, `@SuppressWarnings("deprecation")` is now removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10724: KAFKA-12808: Remove Deprecated Methods under StreamsMetrics
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10724:
URL: https://github.com/apache/kafka/pull/10724#issuecomment-845187840
You are right, I'll fix those later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10724: KAFKA-12808: Remove Deprecated Methods under StreamsMetrics
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10724:
URL: https://github.com/apache/kafka/pull/10724#issuecomment-845858583
Thank you for the review @cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #10724: KAFKA-12808: Remove Deprecated Methods under StreamsMetrics
Posted by GitBox <gi...@apache.org>.
cadonna merged pull request #10724:
URL: https://github.com/apache/kafka/pull/10724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org