You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "LahmerIlyas (via GitHub)" <gi...@apache.org> on 2023/04/03 02:38:01 UTC
[GitHub] [superset] LahmerIlyas opened a new pull request, #23554: fix(chart-table): fixed export full csv not working
LahmerIlyas opened a new pull request, #23554:
URL: https://github.com/apache/superset/pull/23554
### SUMMARY
Exporting the full CSV on the table chart with server pagination was not working properly as it was exporting only the selected page.
After investigation, I found that the issue is because the row limit was being overridden. As a fix, I added a check to verify if the result type is full, and in that case, we won't allow editing the row_limit prop.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
[Bug Solution After.webm](https://user-images.githubusercontent.com/31275446/229398750-5708a65f-6f7b-4493-9e0d-6bb91320715e.webm)
### TESTING INSTRUCTIONS
- On your config.py file, you need to enable `ALLOW_FULL_CSV_EXPORT` flag
- Go to a table with server pagination enabled
- On the action menu, select download and click on `Export FULL CSV`
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue: Fixes #20724
- [ ] Required feature flags: ALLOW_FULL_CSV_EXPORT
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mike-fischer1 commented on pull request #23554: fix(chart-table): fixed export full csv not working
Posted by "mike-fischer1 (via GitHub)" <gi...@apache.org>.
mike-fischer1 commented on PR #23554:
URL: https://github.com/apache/superset/pull/23554#issuecomment-1555942842
anyone able to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23554: fix(chart-table): fixed export full csv not working
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23554:
URL: https://github.com/apache/superset/pull/23554#issuecomment-1493595531
## [Codecov](https://codecov.io/gh/apache/superset/pull/23554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23554](https://codecov.io/gh/apache/superset/pull/23554?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f10f673) into [master](https://codecov.io/gh/apache/superset/commit/bd0609df5874ec8eca1ca6e0d56c8236ec1fcce9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd0609d) will **not change** coverage.
> The diff coverage is `0.00%`.
> :exclamation: Current head f10f673 differs from pull request most recent head f028456. Consider uploading reports for the commit f028456 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23554 +/- ##
=======================================
Coverage 67.70% 67.70%
=======================================
Files 1914 1914
Lines 73962 73962
Branches 8030 8030
=======================================
Hits 50077 50077
Misses 21838 21838
Partials 2047 2047
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.94% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/plugins/plugin-chart-table/src/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/23554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL2J1aWxkUXVlcnkudHM=) | `56.25% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #23554: fix(chart-table): fixed export full csv not working
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #23554:
URL: https://github.com/apache/superset/pull/23554#issuecomment-1569236508
Thank you for this fix! Do you mind writing a test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke commented on pull request #23554: fix(chart-table): fixed export full csv not working
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #23554:
URL: https://github.com/apache/superset/pull/23554#issuecomment-1708436039
@LahmerIlyas bumping this - are you able to add a test to this PR? Let us know if you need support to keep this moving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(chart-table): fixed export full csv not working [superset]
Posted by "AndikaPramana (via GitHub)" <gi...@apache.org>.
AndikaPramana commented on PR #23554:
URL: https://github.com/apache/superset/pull/23554#issuecomment-2094891805
Hi, Thank you for this fix. Bumping up old PR as I need this feature to work on large dataset.
Anyone able to help add test to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org