You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2017/11/21 15:02:14 UTC

Review Request 63985: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63985/
-----------------------------------------------------------

Review request for sentry.


Bugs: sentry-2056
    https://issues.apache.org/jira/browse/sentry-2056


Repository: sentry


Description
-------

The test-patch.py is used by Jenkins to build and test the sentry code. This patch currently sends the output to some artifact files that Jenkins show once the job finished. 

This patches sends the output to the console as well to see the current progress of the Jenkins job console.


Diffs
-----

  dev-support/test-patch.py e44be3a37514b010ec24a78ef327e5b01ec05798 


Diff: https://reviews.apache.org/r/63985/diff/1/


Testing
-------


Thanks,

Sergio Pena


Re: Review Request 63985: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63985/#review191746
-----------------------------------------------------------


Ship it!




looks good

- kalyan kumar kalvagadda


On Nov. 22, 2017, 5:29 p.m., Sergio Pena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63985/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 5:29 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: sentry-2056
>     https://issues.apache.org/jira/browse/sentry-2056
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> The test-patch.py is used by Jenkins to build and test the sentry code. This patch currently sends the output to some artifact files that Jenkins show once the job finished. 
> 
> This patches sends the output to the console as well to see the current progress of the Jenkins job console.
> 
> 
> Diffs
> -----
> 
>   dev-support/test-patch.py e44be3a37 
> 
> 
> Diff: https://reviews.apache.org/r/63985/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>


Re: Review Request 63985: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63985/
-----------------------------------------------------------

(Updated Nov. 22, 2017, 5:29 p.m.)


Review request for sentry.


Bugs: sentry-2056
    https://issues.apache.org/jira/browse/sentry-2056


Repository: sentry


Description
-------

The test-patch.py is used by Jenkins to build and test the sentry code. This patch currently sends the output to some artifact files that Jenkins show once the job finished. 

This patches sends the output to the console as well to see the current progress of the Jenkins job console.


Diffs (updated)
-----

  dev-support/test-patch.py e44be3a37 


Diff: https://reviews.apache.org/r/63985/diff/2/

Changes: https://reviews.apache.org/r/63985/diff/1-2/


Testing
-------


Thanks,

Sergio Pena


Re: Review Request 63985: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63985/#review191744
-----------------------------------------------------------



|| visible in terminal ||   visible in file   || existing
  Syntax  ||  StdOut  |  StdErr  ||  StdOut  |  StdErr  ||   file   
==========++==========+==========++==========+==========++===========
    >     ||    no    |   yes    ||   yes    |    no    || overwrite
    >>    ||    no    |   yes    ||   yes    |    no    ||  append
          ||          |          ||          |          ||
   2>     ||   yes    |    no    ||    no    |   yes    || overwrite
   2>>    ||   yes    |    no    ||    no    |   yes    ||  append
          ||          |          ||          |          ||
   &>     ||    no    |    no    ||   yes    |   yes    || overwrite
   &>>    ||    no    |    no    ||   yes    |   yes    ||  append
          ||          |          ||          |          ||
 | tee    ||   yes    |   yes    ||   yes    |    no    || overwrite
 | tee -a ||   yes    |   yes    ||   yes    |    no    ||  append
          ||          |          ||          |          ||
 n.e. (*) ||   yes    |   yes    ||    no    |   yes    || overwrite
 n.e. (*) ||   yes    |   yes    ||    no    |   yes    ||  append
          ||          |          ||          |          ||
|& tee    ||   yes    |   yes    ||   yes    |   yes    || overwrite
|& tee -a ||   yes    |   yes    ||   yes    |   yes    ||  append


With the approach you have taken, standerr will notbe logged into the file. Instead you should be using "|& tee"

- kalyan kumar kalvagadda


On Nov. 21, 2017, 3:02 p.m., Sergio Pena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63985/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2017, 3:02 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: sentry-2056
>     https://issues.apache.org/jira/browse/sentry-2056
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> The test-patch.py is used by Jenkins to build and test the sentry code. This patch currently sends the output to some artifact files that Jenkins show once the job finished. 
> 
> This patches sends the output to the console as well to see the current progress of the Jenkins job console.
> 
> 
> Diffs
> -----
> 
>   dev-support/test-patch.py e44be3a37514b010ec24a78ef327e5b01ec05798 
> 
> 
> Diff: https://reviews.apache.org/r/63985/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>