[GitHub] [griffin] wankunde commented on a change in pull request #562: [GRIFFIN-316] Fix job exception handling

[GitBox <gi...@apache.org>]

wankunde commented on a change in pull request #562: [GRIFFIN-316] Fix job exception handling
URL: https://github.com/apache/griffin/pull/562#discussion_r363225464
 
 

 ##########
 File path: measure/src/main/scala/org/apache/griffin/measure/step/transform/TransformStep.scala
 ##########
 @@ -67,15 +66,8 @@ trait TransformStep extends DQStep {
         Thread.sleep(1000L)
       }
     })
-    val prepared = parentSteps.forall(step => step.status == COMPLETE)
-    if (prepared) {
-      val res = doExecute(context)
-      info(threadName + " end transform step : \n" + debugString())
-      res
-    } else {
-      error("Parent transform step failed!")
-      false
-    }
+    val prepared = parentSteps.foldLeft(true)((ret, step) => ret && step.status == COMPLETE)
+    doExecute(context)
 
 Review comment:
   I don't understand why change here ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services