You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/08/06 20:22:18 UTC
Review Request 68244: Propagated the verbose build option to bundled
components.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68244/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
Repository: mesos
Description
-------
Automake uses the V= variable to specify whether build rules should be
silent or not. By propagating this flag down into bundled components,
we can ensure that verbose build output is available when it is useful
for build debugging.
Diffs
-----
3rdparty/Makefile.am 6476b043090b24e8a70982a887b21096752b5581
Diff: https://reviews.apache.org/r/68244/diff/1/
Testing
-------
manual comparison of make V=0 vs. make V=1
Thanks,
James Peach
Re: Review Request 68244: Propagated the verbose build option to
bundled components.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68244/#review206927
-----------------------------------------------------------
PASS: Mesos patch 68244 was successfully built and tested.
Reviews applied: `['68244']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2107/mesos-review-68244
- Mesos Reviewbot Windows
On Aug. 6, 2018, 8:22 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68244/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2018, 8:22 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Automake uses the V= variable to specify whether build rules should be
> silent or not. By propagating this flag down into bundled components,
> we can ensure that verbose build output is available when it is useful
> for build debugging.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 6476b043090b24e8a70982a887b21096752b5581
>
>
> Diff: https://reviews.apache.org/r/68244/diff/1/
>
>
> Testing
> -------
>
> manual comparison of make V=0 vs. make V=1
>
>
> Thanks,
>
> James Peach
>
>