[GitHub] [tvm] CircleSpin commented on a diff in pull request #11446: [Onnx] Round operator

[GitBox <gi...@apache.org>]

CircleSpin commented on code in PR #11446:
URL: https://github.com/apache/tvm/pull/11446#discussion_r882248283


##########
python/tvm/relay/frontend/onnx.py:
##########
@@ -4978,10 +4978,30 @@ def _impl_v1(cls, inputs, attr, params):
         return _expr.TupleWrapper(_expr.Tuple(result), len(result))
 
 
+class Round(OnnxOpConverter):
+    """Operator converter for round op."""
+
+    @classmethod
+    def _impl_v11(cls, inputs, attr, params):
+        # See the tutorial for full implementation details:
+        # https://www.youtube.com/watch?v=fZvNG-oKK5Q&list=PL_4zDggB-DBpynCEnC9hV-1euZrP3xDRK&index=4

Review Comment:
   @jwfromm Do you feel that the line 4989 doesn't give enough context in regards to what onnx is doing? 
   
   @AndrewZhaoLuo This was more about having the value of Josh's tutorial accessible. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org