[GitHub] [airflow] uranusjr commented on a diff in pull request #28502: Migrate DagFileProcessor.manage_slas to Internal API

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #28502:
URL: https://github.com/apache/airflow/pull/28502#discussion_r1055145484


##########
airflow/dag_processing/processor.py:
##########
@@ -365,8 +367,10 @@ def __init__(self, dag_ids: list[str] | None, dag_directory: str, log: logging.L
         self._dag_directory = dag_directory
         self.dag_warnings: set[tuple[str, str]] = set()
 
+    @staticmethod
+    @internal_api_call
     @provide_session
-    def manage_slas(self, dag: DAG, session: Session = None) -> None:
+    def manage_slas(dag_folder, dag_id: str, session: Session = None) -> None:

Review Comment:
   ```suggestion
       def manage_slas(dag_folder, dag_id: str, session: Session = NEW_SESSION) -> None:
   ```
   
   Good change to fix this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org