You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/24 01:05:41 UTC
[GitHub] [airflow] kaxil opened a new pull request #11803: Fix bug when marking tasks when DAG Serialization is enabled
kaxil opened a new pull request #11803:
URL: https://github.com/apache/airflow/pull/11803
This is because `current_task` is of SerializedBaseOperator type.
tests would be covered in https://github.com/apache/airflow/pull/11335 where we update all the tests to enable DAG Serialization.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11803: Fix bug when marking tasks when DAG Serialization is enabled
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11803:
URL: https://github.com/apache/airflow/pull/11803#issuecomment-715927237
> Shoudl we add some tests @kaxil ?
Check the PR description 😀
tests would be covered in #11335 where we update all the tests to enable DAG Serialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11803: Fix bug when marking tasks when DAG Serialization is enabled
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11803:
URL: https://github.com/apache/airflow/pull/11803#issuecomment-715653167
CI is green @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11803: Fix bug when marking tasks when DAG Serialization is enabled
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11803:
URL: https://github.com/apache/airflow/pull/11803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11803: Fix bug when marking tasks when DAG Serialization is enabled
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11803:
URL: https://github.com/apache/airflow/pull/11803#issuecomment-715926874
Shoudl we add some tests @kaxil ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org