[GitHub] [incubator-superset] villebro commented on a change in pull request #9033: feat: Add schema to function retrieval and implement for Snowflake

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9033: feat: Add schema to function retrieval and implement for Snowflake
URL: https://github.com/apache/incubator-superset/pull/9033#discussion_r372778140
 
 

 ##########
 File path: superset/db_engine_specs/hive.py
 ##########
 @@ -429,12 +429,26 @@ def execute(  # type: ignore
 
     @classmethod
     @cache.memoize()
-    def get_function_names(cls, database: "Database") -> List[str]:
+    def _get_function_names(cls, database: "Database") -> List[str]:
 
 Review comment:
   Very good point. Somehow I instinctively wanted to avoid the overhead of regenerating the nested function, but seems I grossly overestimated the cost: "[...]it takes less time than creating an empty dict" https://stackoverflow.com/questions/7839632/is-there-an-overhead-when-nesting-functions-in-python

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org