You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Ilya Ganelin (JIRA)" <ji...@apache.org> on 2016/05/23 22:38:13 UTC
[jira] [Commented] (BEAM-88) DataflowPipelineOptions.tempLocation
doesn't really default to stagingLocation
[ https://issues.apache.org/jira/browse/BEAM-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297261#comment-15297261 ]
Ilya Ganelin commented on BEAM-88:
----------------------------------
Hi - I'd like to fix this. Would it make sense to add this logic in the PipelineOptionsFactory? Is that a common utility used to create DataflowPipelineOptions?
> DataflowPipelineOptions.tempLocation doesn't really default to stagingLocation
> ------------------------------------------------------------------------------
>
> Key: BEAM-88
> URL: https://issues.apache.org/jira/browse/BEAM-88
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Eugene Kirpichov
> Priority: Trivial
>
> The documentation of DataflowPipelineOptions.tempLocation says: ..."defaults to using stagingLocation."...
> However calling .getTempLocation() when only --stagingLocation is specified on the command line gives null.
> The "defaulting" is really done in DataflowPipelineRunner.fromOptions():
> {code}
> if (Strings.isNullOrEmpty(dataflowOptions.getTempLocation())) {
> dataflowOptions.setTempLocation(dataflowOptions.getStagingLocation());
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)