You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/22 08:18:52 UTC

Review Request 38606: Added ability to check if the streaming decoder is writing to a body pipe.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38606/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Vinod Kone.


Repository: mesos


Description
-------

This is necessary to know when the decoder has finished writing the latest response, and is needed for the subsequent patch that adds an http::Connection.


Diffs
-----

  3rdparty/libprocess/src/decoder.hpp 67a5135f302153e376e8dfe8db82aa0b15449389 
  3rdparty/libprocess/src/tests/decoder_tests.cpp 6994fa96d33209f9a367b8c3bb09b0d050023fad 

Diff: https://reviews.apache.org/r/38606/diff/


Testing
-------

Updated the streaming tests.


Thanks,

Ben Mahler


Re: Review Request 38606: Added ability to check if the streaming decoder is writing to a body pipe.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38606/#review101549
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38606/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is necessary to know when the decoder has finished writing the latest response, and is needed for the subsequent patch that adds an http::Connection.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/decoder.hpp 67a5135f302153e376e8dfe8db82aa0b15449389 
>   3rdparty/libprocess/src/tests/decoder_tests.cpp 6994fa96d33209f9a367b8c3bb09b0d050023fad 
> 
> Diff: https://reviews.apache.org/r/38606/diff/
> 
> 
> Testing
> -------
> 
> Updated the streaming tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>