You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/01/09 05:15:29 UTC
[GitHub] zeppelin pull request #1875: [ZEPPELIN-1926] Remove grunt googlefonts task
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1875
[ZEPPELIN-1926] Remove grunt googlefonts task
### What is this PR for?
There is no reason to download fonts files whenever we build.
- Google font doesn't change frequently.
- We can use google fonts in open source (https://developers.google.com/fonts/faq)
> Yes. The open source fonts in the Google Fonts catalog are published under licenses that allow you to use them on any website, whether it\u2019s commercial or personal.
### What type of PR is it?
[Improvement]
### Todos
Fixed at once
### What is the Jira issue?
[ZEPPELIN-1926](https://issues.apache.org/jira/browse/ZEPPELIN-1926)
### How should this be tested?
1. Run zeppelin-web dev mode
2. Open browser and check 404
### Screenshots (if appropriate)
None
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-1926/remove-grunt-googlefonts-task
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1875.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1875
----
commit c752edb31d1fa7a14a7b7d5988637852336ef382
Author: 1ambda <1a...@gmail.com>
Date: 2017-01-09T00:10:33Z
fix: Remove grunt googlefonts
commit 27d6c7fef6a32ad4d3316f8070b8e0f27573908a
Author: 1ambda <1a...@gmail.com>
Date: 2017-01-09T00:10:42Z
chore: Add fonts files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1875
@Leemoonsoo I moved all font-related licenses from `bin_license` to `/LICENSE`
Aldo remove rat exclusion in `zeppeiln-web/pom.xml` for `google-fonts.css` because it is managed by us now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1875
@jongyoul small amount of :)
if you want to reduce time for `npm install`, you can use `yarn install` instead of. It will decrease 20~50 secs.
And https://github.com/apache/zeppelin/pull/1812 was merged recently so it is applied to `zeppelin-web` module now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1875
@felixcheung
I think it's ok since all LICENSEs will be merged into a single file
- https://github.com/apache/zeppelin/blob/master/dev/create_release.sh#L93-#L96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1875: [ZEPPELIN-1926] Remove grunt googlefonts task
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1875
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1875
@Leemoonsoo Thanks for detailed explanation. I will take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1875
LGTM and merge to master if no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1875
Honestly, I want to compole web in 30 secs. Do you make it possible? Kkkkkkkk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1875
hmm, it doesn't break RAT tests for all these binaries? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1875
This PR makes zeppelin source distribution package contains font files.
Therefore, related font license should be moved from [`/zeppelin-distribution/src/bin-license/LICENSE`](https://github.com/apache/zeppelin/blob/master/zeppelin-distribution/src/bin_license/LICENSE) to [`/LICENSE`](https://github.com/apache/zeppelin/blob/master/LICENSE).
And license of each font may different. So each license of font need to be listed in [`/LICENSE`](https://github.com/apache/zeppelin/blob/master/LICENSE) file.
@1ambda Could you take care of license?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1875
@1ambda Does it reduce the build time of web module?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---