You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/10/19 19:27:32 UTC
[PR] [57_maintenance] Fix MSRV check by checking in Cargo.lock [arrow-rs]
alamb opened a new pull request, #11728:
URL: https://github.com/apache/arrow-rs/pull/11728
# Which issue does this PR close?
- Part of #11666 (57.3.2 release)
# Rationale for this change
The `Verify MSRV` job fails on PRs against `57_maintenance` (for example #11726) for reasons unrelated to those PRs. This branch does not commit a `Cargo.lock`, so `cargo msrv verify` resolves fresh and picks the newest releases, some of which require a Rust version above the branch MSRV of 1.85:
```text
uuid@1.28.0 requires rustc 1.89.0
tonic@0.14.6 requires rustc 1.88
tonic-prost@0.14.6 requires rustc 1.88
tonic-build@0.14.6 requires rustc 1.88
tonic-prost-build@0.14.6 requires rustc 1.88
```
# What changes are included in this PR?
Check in the root `Cargo.lock`. It is generated with Rust 1.85 using the MSRV-aware resolver, so it pins the `tonic` 0.14 crates to 0.14.5 and `uuid` to 1.26.1. This is the same approach as https://github.com/apache/arrow-rs/pull/9941 ("Fix MSRV check by checking in Cargo.lock") on `main`.
# Are these changes tested?
- `cargo msrv verify` passes for the eight packages that previously failed (`parquet-variant`, `parquet-variant-compute`, `parquet-variant-json`, `parquet_derive_test`, `arrow-avro`, `arrow-flight`, `arrow-flight/gen`, `arrow-integration-testing`).
- `cargo +1.85.0 check --workspace --locked` passes.
# Are there any user-facing changes?
No. This only affects dependency resolution for workspace builds and CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [57_maintenance] Fix MSRV check by checking in Cargo.lock, backport #9888, #10433, #11305 [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11728:
URL: https://github.com/apache/arrow-rs/pull/11728#issuecomment-6298453840
> Thanks @alamb! Can we update the PR title with the PRs that got cherry-picked for the changelog?
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [57_maintenance] Fix MSRV check by checking in Cargo.lock, backport #9888, #10433, #11305 [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #11728:
URL: https://github.com/apache/arrow-rs/pull/11728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [57_maintenance] Fix MSRV check by checking in Cargo.lock [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11728:
URL: https://github.com/apache/arrow-rs/pull/11728#issuecomment-6297490957
The two remaining CI failures were unrelated to the Cargo.lock change, so I cherry-picked the upstream fixes for them onto this branch:
- **MIRI**: `datatype_parse::test::parse_data_type_errors` asserted on the exact `TryFromIntError` message, which changed in recent nightlies. Backported #10433, which only checks the stable prefix.
- **Archery**: upstream archery now runs the C Data Interface tests for `binaryview`, `listview` and `runendencoded` against Rust, and the 57 integration-test JSON parser didn't know those type names. Backported #9888, which adds them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org