[PR] Fix flaky trace snapshot-fallback tests racing async snapshot persist [skywalking-banyandb]

["hanahmily (via GitHub)" <gi...@apache.org>]

hanahmily opened a new pull request, #1276:
URL: https://github.com/apache/skywalking-banyandb/pull/1276

   ## Summary
   
   `TestTraceInitTSTableDeletesMultipleFailedSnapshotsOnFallback` (and its sibling `TestTraceTolerantLoaderFallbackToOlderSnapshot`) flaked in CI with `"0" is not greater than or equal to "1"` — no `.snp` files found after `Close()`.
   
   Root cause: the tests gated on the **part directory**, which is created at the *start* of `mustFlush`. The snapshot manifest (".snp") is persisted asynchronously *after* the part, so the wait could be satisfied before the snapshot write, and `Close()` raced it.
   
   Fix: wait for the persisted `.snp` file itself before closing — the same cure already applied to the measure/stream sibling tests (`waitForPersistedSnapshot` in measure, inline wait in stream). Also drops the `time.Sleep(100ms)` workaround.
   
   ## Test plan
   
   - [x] `go test ./banyand/trace/ -run 'TestTraceInitTSTableDeletesMultipleFailedSnapshotsOnFallback|TestTraceTolerantLoaderFallbackToOlderSnapshot' -count=20` — 20/20 pass
   - [x] Full `banyand/trace` snapshot suite passes
   - [x] `make pre-push` green (generate, lint, check, vuln-check)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix flaky trace snapshot-fallback tests racing async snapshot persist [skywalking-banyandb]

["hanahmily (via GitHub)" <gi...@apache.org>]

hanahmily merged PR #1276:
URL: https://github.com/apache/skywalking-banyandb/pull/1276


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org