You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/01/31 22:36:04 UTC
Review Request 56139: Removed redundant 'Times(1)' from agent
validation tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
This patch removes calls to `.Times(1)` from `EXPECT_CALL`
invocations in the agent validation tests because it is
redundant.
Diffs
-----
src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8
Diff: https://reviews.apache.org/r/56139/diff/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="*Validation*"`
Thanks,
Greg Mann
Re: Review Request 56139: Removed redundant 'Times(1)' from master
validation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Jan. 31, 2017, 11:38 p.m., Vinod Kone wrote:
> > The description says "agent validation tests" but this file is master validation tests. Are you going to fix agent validation tests as well?
Ah sorry, that was just some crossed wires in my brain. There aren't any such occurrences in the agent validation tests; I checked :)
I can do a sweep of the rest of the tests though; it'll be simple enough to update everything.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/#review163739
-----------------------------------------------------------
On Feb. 1, 2017, midnight, Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56139/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, midnight)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes calls to `.Times(1)` from `EXPECT_CALL`
> invocations in the master validation tests because it is
> redundant.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8
>
> Diff: https://reviews.apache.org/r/56139/diff/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="*Validation*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56139: Removed redundant 'Times(1)' from agent
validation tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/#review163739
-----------------------------------------------------------
Ship it!
The description says "agent validation tests" but this file is master validation tests. Are you going to fix agent validation tests as well?
- Vinod Kone
On Jan. 31, 2017, 10:36 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56139/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 10:36 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes calls to `.Times(1)` from `EXPECT_CALL`
> invocations in the agent validation tests because it is
> redundant.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8
>
> Diff: https://reviews.apache.org/r/56139/diff/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="*Validation*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56139: Removed redundant 'Times(1)' from agent
validation tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/#review163729
-----------------------------------------------------------
Bad patch!
Reviews applied: [56139, 56053, 56052, 56055, 55955, 55954]
Failed command: python support/apply-reviews.py -n -r 56053
Error:
2017-01-31 22:42:36 URL:https://reviews.apache.org/r/56053/diff/raw/ [4942/4942] -> "56053.patch" [1]
error: patch failed: src/tests/slave_validation_tests.cpp:129
error: src/tests/slave_validation_tests.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/16935/console
- Mesos Reviewbot
On Jan. 31, 2017, 10:36 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56139/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 10:36 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes calls to `.Times(1)` from `EXPECT_CALL`
> invocations in the agent validation tests because it is
> redundant.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8
>
> Diff: https://reviews.apache.org/r/56139/diff/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="*Validation*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56139: Removed redundant 'Times(1)' from master
validation tests.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/#review163951
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Feb. 1, 2017, 1 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56139/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 1 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes calls to `.Times(1)` from `EXPECT_CALL`
> invocations in the master validation tests because it is
> redundant.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8
>
> Diff: https://reviews.apache.org/r/56139/diff/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="*Validation*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56139: Removed redundant 'Times(1)' from master
validation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 11:24 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebase.
Repository: mesos
Description
-------
This patch removes calls to `.Times(1)` from `EXPECT_CALL`
invocations in the master validation tests because it is
redundant.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26
Diff: https://reviews.apache.org/r/56139/diff/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="*Validation*"`
Thanks,
Greg Mann
Re: Review Request 56139: Removed redundant 'Times(1)' from master
validation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 6:35 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebase.
Repository: mesos
Description
-------
This patch removes calls to `.Times(1)` from `EXPECT_CALL`
invocations in the master validation tests because it is
redundant.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 0c2649089d7fd29eb021ac75c71e6a74368577dc
Diff: https://reviews.apache.org/r/56139/diff/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="*Validation*"`
Thanks,
Greg Mann
Re: Review Request 56139: Removed redundant 'Times(1)' from master
validation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/
-----------------------------------------------------------
(Updated Feb. 1, 2017, midnight)
Review request for mesos and Vinod Kone.
Summary (updated)
-----------------
Removed redundant 'Times(1)' from master validation tests.
Repository: mesos
Description (updated)
-------
This patch removes calls to `.Times(1)` from `EXPECT_CALL`
invocations in the master validation tests because it is
redundant.
Diffs
-----
src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8
Diff: https://reviews.apache.org/r/56139/diff/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="*Validation*"`
Thanks,
Greg Mann