You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ivy-commits@incubator.apache.org by "Nat (JIRA)" <ji...@apache.org> on 2007/06/30 01:57:04 UTC

[jira] Created: (IVY-551) File buffer should be increased to 64KB

File buffer should be increased to 64KB
---------------------------------------

                 Key: IVY-551
                 URL: https://issues.apache.org/jira/browse/IVY-551
             Project: Ivy
          Issue Type: Improvement
          Components: Core
    Affects Versions: 2.0.0-alpha-1
            Reporter: Nat
             Fix For: 2.0.0-alpha-2


File copy is slow because the buffer is too small. Increasing file buffer should alleviate the problem while NIO should be explored as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (IVY-551) File buffer should be increased to 64KB

Posted by "Xavier Hanin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/IVY-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511167 ] 

Xavier Hanin commented on IVY-551:
----------------------------------

Ivy has not been really designed for multi threading, but I know that it is used in multi threaded environment at least in IvyDE. Since it isn't designed for that it may be the cause of some problems, but using only one buffer would be the source of a lot of problems in this case I think.

What could be done is to use one buffer per thread (using a thread local). But I don't know if it will really improve performance. We would need time for testing, and I haven't enough time for the moment. But if you have some, using a thread local buffer shouldn't be too difficult to implement, so feel free to give it a try, run some benchmark and report your results.

> File buffer should be increased to 64KB
> ---------------------------------------
>
>                 Key: IVY-551
>                 URL: https://issues.apache.org/jira/browse/IVY-551
>             Project: Ivy
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-alpha-1
>            Reporter: Nat
>            Assignee: Xavier Hanin
>             Fix For: 2.0.0-alpha-2
>
>
> File copy is slow because the buffer is too small. Increasing file buffer should alleviate the problem while NIO should be explored as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (IVY-551) File buffer should be increased to 64KB

Posted by "Nat (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/IVY-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511165 ] 

Nat commented on IVY-551:
-------------------------

Is it possible to also reuse buffer across multiple file copy operation if you don't plan to copy file multi-threading? It should reduce pressure on GC which may be the reason why it's slower to copy a lot of files.

> File buffer should be increased to 64KB
> ---------------------------------------
>
>                 Key: IVY-551
>                 URL: https://issues.apache.org/jira/browse/IVY-551
>             Project: Ivy
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-alpha-1
>            Reporter: Nat
>            Assignee: Xavier Hanin
>             Fix For: 2.0.0-alpha-2
>
>
> File copy is slow because the buffer is too small. Increasing file buffer should alleviate the problem while NIO should be explored as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (IVY-551) File buffer should be increased to 64KB

Posted by "Xavier Hanin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xavier Hanin reassigned IVY-551:
--------------------------------

    Assignee: Xavier Hanin

> File buffer should be increased to 64KB
> ---------------------------------------
>
>                 Key: IVY-551
>                 URL: https://issues.apache.org/jira/browse/IVY-551
>             Project: Ivy
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-alpha-1
>            Reporter: Nat
>            Assignee: Xavier Hanin
>             Fix For: 2.0.0-alpha-2
>
>
> File copy is slow because the buffer is too small. Increasing file buffer should alleviate the problem while NIO should be explored as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (IVY-551) File buffer should be increased to 64KB

Posted by "Xavier Hanin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xavier Hanin resolved IVY-551.
------------------------------

    Resolution: Fixed

I've increased the file buffer size to 64KB as suggested.

> File buffer should be increased to 64KB
> ---------------------------------------
>
>                 Key: IVY-551
>                 URL: https://issues.apache.org/jira/browse/IVY-551
>             Project: Ivy
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-alpha-1
>            Reporter: Nat
>            Assignee: Xavier Hanin
>             Fix For: 2.0.0-alpha-2
>
>
> File copy is slow because the buffer is too small. Increasing file buffer should alleviate the problem while NIO should be explored as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.