You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kibble.apache.org by "skytin1004 (via GitHub)" <gi...@apache.org> on 2023/05/16 09:44:58 UTC
[GitHub] [kibble] skytin1004 opened a new pull request, #16: Polish in CONTRIBUTING.md
skytin1004 opened a new pull request, #16:
URL: https://github.com/apache/kibble/pull/16
I've cleaned up the text to make it more readable in CONTRIBUTING.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kibble.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] sharanf commented on pull request #16: Polish in CONTRIBUTING.md
Posted by "sharanf (via GitHub)" <gi...@apache.org>.
sharanf commented on PR #16:
URL: https://github.com/apache/kibble/pull/16#issuecomment-1585664415
> I've cleaned up the text to make it more readable in CONTRIBUTING.md.
Hi @skytin1004 thanks very much for the contribution and my apologies for not reviewing this earlier. I've highlighted a minor grammar change and once fixed will be good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kibble.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] sharanf commented on a diff in pull request #16: Polish in CONTRIBUTING.md
Posted by "sharanf (via GitHub)" <gi...@apache.org>.
sharanf commented on code in PR #16:
URL: https://github.com/apache/kibble/pull/16#discussion_r1225357254
##########
CONTRIBUTING.md:
##########
@@ -67,9 +67,9 @@ docker run apache/kibble-dev pytest
## Testing
Apache Kibble project uses [pytest](https://docs.pytest.org/en/stable/) for running testing. Writing
-good test helps us avoid regression and unexpected issues.
+the good test helps us avoid regression and unexpected issues.
Review Comment:
Should be 'Writing a good test.. or *Writing good tests helps ....'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kibble.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] skytin1004 commented on a diff in pull request #16: Polish in CONTRIBUTING.md
Posted by "skytin1004 (via GitHub)" <gi...@apache.org>.
skytin1004 commented on code in PR #16:
URL: https://github.com/apache/kibble/pull/16#discussion_r1228890358
##########
CONTRIBUTING.md:
##########
@@ -67,9 +67,9 @@ docker run apache/kibble-dev pytest
## Testing
Apache Kibble project uses [pytest](https://docs.pytest.org/en/stable/) for running testing. Writing
-good test helps us avoid regression and unexpected issues.
+the good test helps us avoid regression and unexpected issues.
Review Comment:
Thank you for the review @sharanf , I modified based on your review.
"Writing good tests help us avoid regression and unexpected issues."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kibble.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] sharanf merged pull request #16: Polish in CONTRIBUTING.md
Posted by "sharanf (via GitHub)" <gi...@apache.org>.
sharanf merged PR #16:
URL: https://github.com/apache/kibble/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kibble.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org