You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2023/04/18 15:02:01 UTC

[GitHub] [sling-org-apache-sling-servlet-helpers] dependabot[bot] opened a new pull request, #15: Bump org.apache.sling.engine from 2.6.22 to 2.14.0

dependabot[bot] opened a new pull request, #15:
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15

   Bumps org.apache.sling.engine from 2.6.22 to 2.14.0.
   
   
   [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.sling:org.apache.sling.engine&package-manager=maven&previous-version=2.6.22&new-version=2.14.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   <details>
   <summary>Dependabot commands and options</summary>
   <br />
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
   You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/sling-org-apache-sling-servlet-helpers/network/alerts).
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump org.apache.sling.engine from 2.6.22 to 2.14.0 [sling-org-apache-sling-servlet-helpers]

Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15#issuecomment-2602610289

   Maybe the newer Sling Engine fails to resolve, leading to the resolution error that you mentioned?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump org.apache.sling.engine from 2.6.22 to 2.14.0 [sling-org-apache-sling-servlet-helpers]

Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] closed pull request #15: Bump org.apache.sling.engine from 2.6.22 to 2.14.0
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump org.apache.sling.engine from 2.6.22 to 2.14.0 [sling-org-apache-sling-servlet-helpers]

Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15#issuecomment-2554178932

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump org.apache.sling.engine from 2.6.22 to 2.14.0 [sling-org-apache-sling-servlet-helpers]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15#issuecomment-2554818408

   Please retry analysis of this Pull-Request directly on SonarQube Cloud


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump org.apache.sling.engine from 2.6.22 to 2.14.0 [sling-org-apache-sling-servlet-helpers]

Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15#issuecomment-2602692242

   hmm, probably, unfortunately i've very little experience with paxexam and this was the only relevant error i've found in the failsafe logs. (and it's suspicious that it starts failing when switching from 2.9.2 to 2.10.2.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump org.apache.sling.engine from 2.6.22 to 2.14.0 [sling-org-apache-sling-servlet-helpers]

Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15#issuecomment-2602945095

   yes, this was the right pointer. i now understand paxexam a bit more.
   
   first of all, the version of sling.engine that is defined in the pom here has nothing to do with the version that is used in the osgi context of paxexam - unless you specfiy it, its the versions defined here https://github.com/apache/sling-org-apache-sling-testing-paxexam/blob/org.apache.sling.testing.paxexam-4.0.0/src/main/java/org/apache/sling/testing/paxexam/SlingVersionResolver.java
   
   and this engine version is too old (there is the 2.9.2) then we depend on here. as described here https://sling.apache.org/documentation/development/testing-paxexam.html it's possible to define different versions to be used by deployed to the osgi container, but this quickly gets out of hand. i managed to use the project version of sling.api and sling.engine, but that required to update resourceresolver and servlets.resolver as well. i stopped when i had to provide jakarta.json as well.
   
   so either we provide a updated sling paxexam with more recent sling version included (but with https://issues.apache.org/jira/browse/SLING-12577 that list of versions was removed altogether), or stick with the security warning and the old engine dependency here.
   
   or remove the paxexam tests...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump org.apache.sling.engine from 2.6.22 to 2.14.0 [sling-org-apache-sling-servlet-helpers]

Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15#issuecomment-2602558087

   build fails due to a problem with the PaxExam tests:
   
   ```
   ERROR: Bundle org.apache.sling.servlet-helpers [201] Error starting file:/Z:/Dev/OpenSource/sling-git/sling-org-apache-sling-servlet-helpers/target/paxexam/ServletInternalRequestIT/dff9fb82-5123-4f4c-8315-05b5f149ec9c/pax-exam-downloads/org.apache.sling.servlet-helpers_1.4.7.SNAPSHOT.jar (org.osgi.framework.BundleException: Unable to resolve org.apache.sling.servlet-helpers [201](R 201.0): missing requirement [org.apache.sling.servlet-helpers [201](R 201.0)] osgi.wiring.package; (&(osgi.wiring.package=org.apache.sling.engine)(version>=2.6.0)(!(version>=3.0.0))) Unresolved requirements: [[org.apache.sling.servlet-helpers [201](R 201.0)] osgi.wiring.package; (&(osgi.wiring.package=org.apache.sling.engine)(version>=2.6.0)(!(version>=3.0.0)))])
   org.osgi.framework.BundleException: Unable to resolve org.apache.sling.servlet-helpers [201](R 201.0): missing requirement [org.apache.sling.servlet-helpers [201](R 201.0)] osgi.wiring.package; (&(osgi.wiring.package=org.apache.sling.engine)(version>=2.6.0)(!(version>=3.0.0))) Unresolved requirements: [[org.apache.sling.servlet-helpers [201](R 201.0)] osgi.wiring.package; (&(osgi.wiring.package=org.apache.sling.engine)(version>=2.6.0)(!(version>=3.0.0)))]
   	at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4398)
   	at org.apache.felix.framework.Felix.startBundle(Felix.java:2308)
   	at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1566)
   	at org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:297)
   	at java.base/java.lang.Thread.run(Thread.java:842)
   ```
   
   it works if raising sling engine dependency up to 2.9.2, but once going further beyond that e.g. 2.10.2 or 2.14.0 build fails.
   it looks as if the version comparison is done wrong and starts failing once the minor version reaches 10 - but such a bug is very unlikely in the used osgi framework?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump org.apache.sling.engine from 2.6.22 to 2.14.0 [sling-org-apache-sling-servlet-helpers]

Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15#issuecomment-2602707378

   FWIW, the Sling Engine 2.14.2 exports the same 2.6.0 version of the `org.apache.sling.engine` package:
   
   ```
   Export-Package
     org.apache.sling.engine                {version=2.6.0, imported-as=[2.6,2.7)}
     org.apache.sling.engine.jmx            {version=1.1.1, imported-as=[1.1,1.2)}
     org.apache.sling.engine.servlets       {version=2.0.9, imported-as=[2.0,3)}
   ```
   
   Maybe the problems comes from the capability list?
   
   ```
   Require-Capability                      osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"
                                           osgi.extender;filter:="(&(osgi.extender=osgi.component)(version>=1.4.0)(!(version>=2.0.0)))"
                                           osgi.implementation;filter:="(&(osgi.implementation=osgi.http)(version>=1.1.0)(!(version>=2.0.0)))"
                                           osgi.service;filter:="(objectClass=javax.servlet.Filter)";effective:=active;resolution:=optional;cardinality:=multiple
                                           osgi.service;filter:="(objectClass=javax.servlet.ServletContext)";effective:=active
                                           osgi.service;filter:="(objectClass=org.apache.sling.api.adapter.AdapterManager)";effective:=active;resolution:=optional
                                           osgi.service;filter:="(objectClass=org.apache.sling.api.request.SlingRequestListener)";effective:=active;resolution:=optional;cardinality:=multiple
                                           osgi.service;filter:="(objectClass=org.apache.sling.api.servlets.ServletResolver)";effective:=active
                                           osgi.service;filter:="(objectClass=org.apache.sling.auth.core.AuthenticationSupport)";effective:=active
                                           osgi.service;filter:="(objectClass=org.apache.sling.commons.mime.MimeTypeService)";effective:=active;resolution:=optional
                                           osgi.service;filter:="(objectClass=org.apache.sling.engine.RequestInfoProvider)";effective:=active
                                           osgi.service;filter:="(objectClass=org.apache.sling.engine.impl.ProductInfoProvider)";effective:=active
                                           osgi.service;filter:="(objectClass=org.apache.sling.engine.impl.RequestProcessorMBeanImpl)";effective:=active
                                           osgi.service;filter:="(objectClass=org.apache.sling.engine.impl.SlingRequestProcessorImpl)";effective:=active
                                           osgi.service;filter:="(objectClass=org.apache.sling.engine.impl.filter.ServletFilterManager)";effective:=active
                                           osgi.service;filter:="(objectClass=org.apache.sling.engine.impl.helper.RequestListenerManager)";effective:=active;resolution:=optional
                                           osgi.service;filter:="(objectClass=org.apache.sling.engine.impl.log.RequestLoggerService)";effective:=active;cardinality:=multiple
                                           osgi.service;filter:="(objectClass=org.apache.sling.engine.servlets.ErrorHandler)";effective:=active;resolution:=optional
                                           osgi.service;filter:="(objectClass=org.apache.sling.settings.SlingSettingsService)";effective:=active
   
   ```
   
   (this is gathered using `bnd print`, BTW)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump org.apache.sling.engine from 2.6.22 to 2.14.0 [sling-org-apache-sling-servlet-helpers]

Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15#issuecomment-3208144398

   Looks like org.apache.sling:org.apache.sling.engine is up-to-date now, so this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump org.apache.sling.engine from 2.6.22 to 2.14.0 [sling-org-apache-sling-servlet-helpers]

Posted by "enapps-enorman (via GitHub)" <gi...@apache.org>.
enapps-enorman commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15#issuecomment-3208142978

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump org.apache.sling.engine from 2.6.22 to 2.14.0 [sling-org-apache-sling-servlet-helpers]

Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on PR #15:
URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/15#issuecomment-2554023449

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org