[GitHub] [netbeans] mbien commented on a diff in pull request #5842: Load bundled GraalJS, give priority to GraalVM if present.

["mbien (via GitHub)" <gi...@apache.org>]

mbien commented on code in PR #5842:
URL: https://github.com/apache/netbeans/pull/5842#discussion_r1170607255


##########
harness/nbjunit/src/org/netbeans/junit/NbTestCase.java:
##########
@@ -474,6 +476,8 @@ public synchronized void waitFinished(final int timeout) throws Throwable {
                     long now = System.nanoTime();
                     try {
                         runTest();
+                    } catch (AssumptionViolatedException ex) {
+                        // ignore, the test is assumed to be meaningless.

Review Comment:
   awesome. This will make the test case show up as green though, not skipped, right?
   
   I actually wanted to implement this myself but got distracted before I figured out how to communicate this to junit properly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists