You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/01 19:49:09 UTC

[GitHub] srowen commented on a change in pull request #23931: [SPARK-26048][build] Enable flume profile when creating 2.x releases.

srowen commented on a change in pull request #23931: [SPARK-26048][build] Enable flume profile when creating 2.x releases.
URL: https://github.com/apache/spark/pull/23931#discussion_r261736060
 
 

 ##########
 File path: dev/create-release/release-build.sh
 ##########
 @@ -116,14 +116,17 @@ SCALA_2_11_PROFILES=
 if [[ $SPARK_VERSION > "2.3" ]]; then
   BASE_PROFILES="$BASE_PROFILES -Pkubernetes"
   if [[ $SPARK_VERSION < "3.0." ]]; then
-    SCALA_2_11_PROFILES="-Pkafka-0-8"
+    SCALA_2_11_PROFILES="-Pkafka-0-8 -Pflume"
   fi
 
 Review comment:
   I had thought the same, but I think the practice is to let the main script create releases for prior branches too. I'd defer to release managers for policy on this. We ought to be able to drop support in the script for EOL releases. I did that a while ago in order to keep it at all sane after adding scala 2.12 support.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org