You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <ch...@yahoo-inc.com> on 2012/10/20 04:01:43 UTC
Review Request: OOZIE-1027 Command line mr does not support NN/JT parameters
properly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7680/
-----------------------------------------------------------
Review request for oozie.
Description
-------
See JIRA description
This addresses bug OOZIE-1027.
https://issues.apache.org/jira/browse/OOZIE-1027
Diffs
-----
http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1399938
http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/core/src/main/java/org/apache/oozie/command/wf/SubmitMRXCommand.java 1399938
http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1399938
Diff: https://reviews.apache.org/r/7680/diff/
Testing
-------
Performed end-to-end test with new set of NN/JT properties as well as older set
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1027 Command line mr does not support NN/JT
parameters properly
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7680/#review12688
-----------------------------------------------------------
Ship it!
Ship It!
- Mohammad Islam
On Oct. 22, 2012, 9:11 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7680/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2012, 9:11 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> See JIRA description
>
>
> This addresses bug OOZIE-1027.
> https://issues.apache.org/jira/browse/OOZIE-1027
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1399938
> http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/core/src/main/java/org/apache/oozie/command/wf/SubmitMRXCommand.java 1399938
> http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1399938
>
> Diff: https://reviews.apache.org/r/7680/diff/
>
>
> Testing
> -------
>
> Performed end-to-end test with new set of NN/JT properties as well as older set
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1027 Command line mr does not support NN/JT
parameters properly
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7680/#review12668
-----------------------------------------------------------
just minor comments.
----
106 if (JT == null)
107 if(JT_2 == null) {
----
instead of nested if, might be better to do in one line, if (JT == null && JT_2 == null) ?
the same goes to line 114-115
- Ryota Egashira
On Oct. 22, 2012, 9:11 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7680/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2012, 9:11 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> See JIRA description
>
>
> This addresses bug OOZIE-1027.
> https://issues.apache.org/jira/browse/OOZIE-1027
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1399938
> http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/core/src/main/java/org/apache/oozie/command/wf/SubmitMRXCommand.java 1399938
> http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1399938
>
> Diff: https://reviews.apache.org/r/7680/diff/
>
>
> Testing
> -------
>
> Performed end-to-end test with new set of NN/JT properties as well as older set
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1027 Command line mr does not support NN/JT
parameters properly
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7680/
-----------------------------------------------------------
(Updated Oct. 22, 2012, 9:11 p.m.)
Review request for oozie.
Changes
-------
1. hadoop 23 ConfigUtils converts 'user.name' to 'mapreduce.job.user.name', so added handling this in the 'DEPRECATED_MAP' so that its not added to the action's conf.
2. fixed failing unit test reported by the bot
Description
-------
See JIRA description
This addresses bug OOZIE-1027.
https://issues.apache.org/jira/browse/OOZIE-1027
Diffs (updated)
-----
http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/client/src/main/java/org/apache/oozie/client/XOozieClient.java 1399938
http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/core/src/main/java/org/apache/oozie/command/wf/SubmitMRXCommand.java 1399938
http://svn.apache.org/repos/asf/oozie/branches/branch-3.3/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1399938
Diff: https://reviews.apache.org/r/7680/diff/
Testing
-------
Performed end-to-end test with new set of NN/JT properties as well as older set
Thanks,
Mona Chitnis