You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/06/11 09:58:48 UTC
Review Request 67521: Made some headers standalone.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67521/
-----------------------------------------------------------
Review request for mesos and Jan Schlicht.
Repository: mesos
Description
-------
This patch adds includes to two header files in stout so that the
headers are standalone.
Diffs
-----
3rdparty/stout/include/stout/os/posix/copyfile.hpp bb5ec71b9a083f1af0c1a729377ee56842d1b734
3rdparty/stout/include/stout/os/posix/stat.hpp 8bb8e2c25e1677056b165fe8a7f61f57b4127522
Diff: https://reviews.apache.org/r/67521/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 67521: Made some headers standalone.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67521/#review204536
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67521]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 11, 2018, 9:58 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67521/
> -----------------------------------------------------------
>
> (Updated June 11, 2018, 9:58 a.m.)
>
>
> Review request for mesos and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds includes to two header files in stout so that the
> headers are standalone.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/copyfile.hpp bb5ec71b9a083f1af0c1a729377ee56842d1b734
> 3rdparty/stout/include/stout/os/posix/stat.hpp 8bb8e2c25e1677056b165fe8a7f61f57b4127522
>
>
> Diff: https://reviews.apache.org/r/67521/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67521: Made some headers standalone.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67521/#review204533
-----------------------------------------------------------
PASS: Mesos patch 67521 was successfully built and tested.
Reviews applied: `['67521']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67521
- Mesos Reviewbot Windows
On June 11, 2018, 9:58 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67521/
> -----------------------------------------------------------
>
> (Updated June 11, 2018, 9:58 a.m.)
>
>
> Review request for mesos and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds includes to two header files in stout so that the
> headers are standalone.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/copyfile.hpp bb5ec71b9a083f1af0c1a729377ee56842d1b734
> 3rdparty/stout/include/stout/os/posix/stat.hpp 8bb8e2c25e1677056b165fe8a7f61f57b4127522
>
>
> Diff: https://reviews.apache.org/r/67521/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67521: Made some headers standalone.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67521/#review204531
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On June 11, 2018, 11:58 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67521/
> -----------------------------------------------------------
>
> (Updated June 11, 2018, 11:58 a.m.)
>
>
> Review request for mesos and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds includes to two header files in stout so that the
> headers are standalone.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/copyfile.hpp bb5ec71b9a083f1af0c1a729377ee56842d1b734
> 3rdparty/stout/include/stout/os/posix/stat.hpp 8bb8e2c25e1677056b165fe8a7f61f57b4127522
>
>
> Diff: https://reviews.apache.org/r/67521/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>