You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/25 03:26:19 UTC
[GitHub] srkukarni commented on a change in pull request #2840: Handle
builtin/functionpkgurl properly in externally managed schedulers
srkukarni commented on a change in pull request #2840: Handle builtin/functionpkgurl properly in externally managed schedulers
URL: https://github.com/apache/pulsar/pull/2840#discussion_r228024453
##########
File path: conf/functions_worker.yml
##########
@@ -74,12 +74,19 @@ metricsSamplingPeriodSec: 60
#threadContainerFactory:
# threadGroupName: "Thread Function Container Group"
-processContainerFactory:
- logDirectory:
+#processContainerFactory:
+# logDirectory:
# change the jar location only when you put the java instance jar in a different location
- javaInstanceJarLocation:
+# javaInstanceJarLocation:
# change the python instance location only when you put the python instance jar in a different location
- pythonInstanceLocation:
+# pythonInstanceLocation:
+kubernetesContainerFactory:
+ pulsarDockerImageName: "srkukarni/pulsar"
Review comment:
Looks like some testing files got into the checkin. I have removed these changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services