You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ta...@apache.org on 2021/03/24 16:08:52 UTC
[tika] 02/04: TIKA-3336 -- don't doubly advance...prevent new zip
bomb warnings in regression tests for 1.26 release
This is an automated email from the ASF dual-hosted git repository.
tallison pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git
commit de6cf7376e71fb823f6740d401d6875046d6cd4d
Author: tallison <ta...@apache.org>
AuthorDate: Wed Mar 24 11:47:26 2021 -0400
TIKA-3336 -- don't doubly advance...prevent new zip bomb warnings in regression tests for 1.26 release
---
.../src/main/java/org/apache/tika/parser/RecursiveParserWrapper.java | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tika-core/src/main/java/org/apache/tika/parser/RecursiveParserWrapper.java b/tika-core/src/main/java/org/apache/tika/parser/RecursiveParserWrapper.java
index 7857bf4..13e42b1 100644
--- a/tika-core/src/main/java/org/apache/tika/parser/RecursiveParserWrapper.java
+++ b/tika-core/src/main/java/org/apache/tika/parser/RecursiveParserWrapper.java
@@ -352,12 +352,10 @@ public class RecursiveParserWrapper extends ParserDecorator {
@Override
public void characters(char[] ch, int start, int length) throws SAXException {
if (totalWriteLimit < 0) {
- advance(length);
super.characters(ch, start, length);
return;
}
int availableLength = Math.min(totalWriteLimit - totalChars, length);
- advance(availableLength);
super.characters(ch, start, availableLength);
if (availableLength < length) {
throw new WriteLimitReached();
@@ -367,12 +365,10 @@ public class RecursiveParserWrapper extends ParserDecorator {
@Override
public void ignorableWhitespace(char[] ch, int start, int length) throws SAXException {
if (totalWriteLimit < 0) {
- advance(length);
super.ignorableWhitespace(ch, start, length);
return;
}
int availableLength = Math.min(totalWriteLimit - totalChars, length);
- advance(availableLength);
super.ignorableWhitespace(ch, start, availableLength);
if (availableLength < length) {
throw new WriteLimitReached();