You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/03/04 01:54:28 UTC

Review Request 31712: RANGER-287: fix: 'Plugin Id' empty in policy download audit log

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31712/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-287
    https://issues.apache.org/jira/browse/RANGER-287


Repository: ranger


Description
-------

Plugins policy refresher updated to send pluginId; policy download audit log generation updated to populate "Plugin Id" field


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java 9807dd4 
  agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java f6bbebc 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java feef506 
  agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java eaccf7a 
  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java f9b9a3e 
  knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java fa16566 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java ab09bf6 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml a12a097 

Diff: https://reviews.apache.org/r/31712/diff/


Testing
-------

Verified that the pluginId field in policy download audit log shows the pluginId (i.e. values like hbaseMaster@hostname.domain-serviceName/hbaseRegion@hostname.domain-serviceName, which is passed from the plugin)


Thanks,

Madhan Neethiraj


Re: Review Request 31712: RANGER-287: fix: 'Plugin Id' empty in policy download audit log

Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31712/#review75142
-----------------------------------------------------------

Ship it!


Ship It!

- Alok Lal


On March 4, 2015, 12:54 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31712/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 12:54 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-287
>     https://issues.apache.org/jira/browse/RANGER-287
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Plugins policy refresher updated to send pluginId; policy download audit log generation updated to populate "Plugin Id" field
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java 9807dd4 
>   agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java f6bbebc 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java feef506 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java eaccf7a 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java f9b9a3e 
>   knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java fa16566 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java ab09bf6 
>   security-admin/src/main/resources/conf.dist/security-applicationContext.xml a12a097 
> 
> Diff: https://reviews.apache.org/r/31712/diff/
> 
> 
> Testing
> -------
> 
> Verified that the pluginId field in policy download audit log shows the pluginId (i.e. values like hbaseMaster@hostname.domain-serviceName/hbaseRegion@hostname.domain-serviceName, which is passed from the plugin)
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>